Skip to content

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Aug 16, 2025

HHH-19733

We're exploring (@gsmet and me) how to make the enhancer faster - these fixes here are NOT the main bottleneck, but it's useful to get this "noise" out of the profiling data - and they help.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-19733

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Aug 16, 2025

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

@Sanne Sanne changed the title [POC] Some small bytecode Enhancer tweaks HHH-19733 Some small bytecode Enhancer tweaks Aug 21, 2025
@Sanne Sanne marked this pull request as ready for review August 21, 2025 16:06
@Sanne
Copy link
Member Author

Sanne commented Aug 21, 2025

I think it's ready now - or, more accurately, that I should stop :)

@Sanne Sanne changed the title HHH-19733 Some small bytecode Enhancer tweaks HHH-19733 Some small tweaks to the Bytecode Enhancer Aug 21, 2025
Copy link
Member

@beikov beikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT, looks good to me. Bonus points if you change the new/extracted classes to records ;)

@Sanne
Copy link
Member Author

Sanne commented Aug 26, 2025

AFAICT, looks good to me. Bonus points if you change the new/extracted classes to records ;)

ah, I might do it as a lazy follow-up.. but why, what would the benefit be?

@Sanne Sanne merged commit bbfab98 into hibernate:main Aug 26, 2025
26 checks passed
@Sanne Sanne deleted the EnhancerTweaks branch August 26, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants