Skip to content
This repository has been archived by the owner on Mar 16, 2022. It is now read-only.

fix(karma) check if user exists before granting karma #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
534 changes: 267 additions & 267 deletions package-lock.json
19 changes: 9 additions & 10 deletions scripts/karma.coffee
Original file line number Diff line number Diff line change
@@ -23,13 +23,14 @@ scores = [
getUserKarmaExpression = (userKarmaToken) ->
hasAtSymbol = userKarmaToken.startsWith('@')
username = if hasAtSymbol
then userKarmaToken.slice(1, -2)
else userKarmaToken.slice(0, -2)
then userKarmaToken.slice(1, -2)
else userKarmaToken.slice(0, -2)

operator = userKarmaToken.slice(-2)

{
hasAtSymbol,
type: 'UserKarmaExpression',
isMentioned: hasAtSymbol,
username: username.toLowerCase(),
operator
}
@@ -49,15 +50,13 @@ module.exports = (robot) ->
seenUsernames = new Set()
userKarmaExpressions = getUserKarmaExpressions(msg.match)
.filter((expr) ->
# Only keep the first expression seen for per user
if expr.username && seenUsernames.has(expr.username)
# Unless the user has been already been seen,
# Or unless the user does not exist
if !seenUsernames.has(expr.username) and robot.brain.userForName(expr.username)
seenUsernames.add(expr.username)

# don't let user adjust their own score, and ignore "c" unless it
# starts with a "@" because "c++" is probably a mention of the
# language, not a person or thing
expr.username != msg.message.user.name.toLowerCase()) &&
(expr.username !== 'c' || expr.hasAtSymbol)
# don't let user adjust their own score
expr.username != msg.message.user.name.toLowerCase())

for { username, operator } in userKarmaExpressions
# get the current karma points