Skip to content

Updating to meet current lambda config #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ianbender
Copy link
Contributor

@ianbender ianbender commented Mar 10, 2025

Are there any dependencies (software or human) that need to be addressed before this PR is merged?

What ticket(s) or other PRs does this relate to?

https://linear.app/highwing/issue/FOUND-62/remove-legacy-broker-suite-terraform-code

What was the problem or feature?

Tearing down the old Broker Suite infrastructure and terraform folder.

What was the solution?

The current state of this module is no longer in use. Updating to the lambda_engine module that is now being used throughout the Broker and Carrier Suite.
https://github.com/highwingio/broker-suite/tree/main/terraform/modules/lambda_engine

  • Security Impact has been considered (if yes please describe)
  • Network Impacts have been considered (if yes please describe)

Where does this work fall on the Good - Fast spectrum?

Any additional work needed as a result of merging this PR (deploy steps, other PRs, etc.)?

@ianbender ianbender self-assigned this Mar 10, 2025
@plukevdh
Copy link

Didn't realize we had our own internal module. Thought we just used the main TF/AWS module. 👍🏻

@ianbender
Copy link
Contributor Author

Didn't realize we had our own internal module. Thought we just used the main TF/AWS module.
@plukevdh Technically both are true. The BS lambdas use the terraform/module/lambda_engine module, which uses the TF/AWS module. And now I'm just moving that out to public access.

@ianbender ianbender merged commit 2a5ace0 into master Mar 10, 2025
2 checks passed
@ianbender ianbender deleted the ianbender/pt-62-remove-legacy-broker-suite-terraform-code branch March 10, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants