Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: retrieve merge request from commit_sha when CI_MERGE_REQUEST_IID is not provided #47

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

kitagry
Copy link
Contributor

@kitagry kitagry commented Feb 15, 2025

fix #46

@kitagry
Copy link
Contributor Author

kitagry commented Feb 15, 2025

I will check the behavior with GitLab in a few days 🙏

@hirosassa
Copy link
Owner

@kitagry any update on this?

@kitagry
Copy link
Contributor Author

kitagry commented Mar 21, 2025

Thank you for the remind. I'll check this today🙏

@kitagry
Copy link
Contributor Author

kitagry commented Mar 21, 2025

@hirosassa I checked the behavior for this PR. Please review this!

@hirosassa hirosassa marked this pull request as ready for review March 21, 2025 20:37
Copy link
Owner

@hirosassa hirosassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hirosassa hirosassa merged commit a2ca207 into hirosassa:main Mar 21, 2025
4 checks passed
@kitagry
Copy link
Contributor Author

kitagry commented Mar 22, 2025

Thank you!

@kitagry kitagry deleted the search-merge-request-iid branch March 22, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ksnotify failed when CI_MERGE_REQUEST_IID is not found
2 participants