Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): allow global ~/.clarinet/Settings.toml #1208

Merged
merged 7 commits into from
Oct 25, 2023

Conversation

tippenein
Copy link
Collaborator

@tippenein tippenein commented Oct 15, 2023

feat: #205

This adds a global file for clarinet settings

cat ~/.clarinet/Settings.toml 
disable_hints = true
enable_telemetry = true

If the file doesn't exist, it picks the defaults

GlobalSettings {
  disable_hints: false,
  enable_telemetry: None
};

Any thoughts welcome!

I can add documentation wherever seems appropriate

(This should nullify #1207)

@hugocaillard
Copy link
Collaborator

Thanks for this contribution @tippenein

I'll test it sometimes this week, we'll include it in 2.0 🙌

@hugocaillard hugocaillard self-requested a review October 16, 2023 15:36
Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @tippenein
Small improvements requested

components/clarinet-cli/src/frontend/cli.rs Outdated Show resolved Hide resolved
components/clarinet-cli/src/frontend/cli.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @tippenein

Thanks a lot for this contribution and quick responses!

@hugocaillard hugocaillard merged commit bbe26cc into hirosystems:develop Oct 25, 2023
@tippenein tippenein deleted the global-settings-205 branch October 25, 2023 15:56
hugocaillard pushed a commit that referenced this pull request Oct 31, 2023
* add global Settings.toml option

* rustfmt

* fix merge

* code review: use warns and nest err conditions into global defaults
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants