Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing coverage in clarity iterator functions #1220

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

hugocaillard
Copy link
Collaborator

@hugocaillard hugocaillard commented Oct 24, 2023

The first argument of map, filter and fold doesn't trigger will_eval_hook. Leading to false negative in coverage reports.
But it's safe to assume that this expr is hit of the map, filter or fold is hit as well.

Copy link
Contributor

@lgalabru lgalabru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 and thank you for adding the tests!

@hugocaillard hugocaillard merged commit 336b580 into develop Oct 24, 2023
15 checks passed
@hugocaillard hugocaillard deleted the fix/coverage-gaps branch October 24, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants