Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add coverage #1241

Merged
merged 1 commit into from
Nov 10, 2023
Merged

ci: add coverage #1241

merged 1 commit into from
Nov 10, 2023

Conversation

hugocaillard
Copy link
Collaborator

Description

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #1241 (7eafe20) into develop (a2a21d8) will decrease coverage by 13.27%.
Report is 1200 commits behind head on develop.
The diff coverage is 7.67%.

@@             Coverage Diff              @@
##           develop    #1241       +/-   ##
============================================
- Coverage    34.02%   20.76%   -13.27%     
============================================
  Files          180       78      -102     
  Lines        47486    23784    -23702     
============================================
- Hits         16158     4939    -11219     
+ Misses       31328    18845    -12483     
Flag Coverage Δ
unittests 20.76% <7.67%> (-13.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
components/clarinet-cli/src/bin.rs 0.00% <ø> (-25.00%) ⬇️
components/clarinet-cli/src/deployments/ui/app.rs 0.00% <ø> (ø)
components/clarinet-cli/src/deployments/ui/mod.rs 0.00% <ø> (ø)
components/clarinet-cli/src/generate/changes.rs 0.00% <ø> (ø)
components/clarinet-cli/src/generate/mod.rs 0.00% <ø> (ø)
...ents/clarinet-deployments/src/diagnostic_digest.rs 0.00% <ø> (ø)
components/clarinet-deployments/src/lib.rs 55.55% <ø> (+10.72%) ⬆️
...inet-deployments/src/onchain/bitcoin_deployment.rs 0.00% <ø> (ø)
components/clarinet-deployments/src/onchain/mod.rs 0.00% <ø> (ø)
...omponents/clarinet-deployments/src/requirements.rs 58.40% <ø> (+58.39%) ⬆️
... and 36 more

... and 89 files with indirect coverage changes

codecov.yml Outdated Show resolved Hide resolved
@hugocaillard
Copy link
Collaborator Author

hugocaillard commented Nov 9, 2023

@CharlieC3
I added back the the codecov report on the "old" ci.
Unfortunately, we are still not using the new, faster version (which should be even faster now that we removed Deno).

But now that this repo is in a more stable state (post clarinet v2 release), it'll make more sense to work on a clean CI and workflow.
Reporting the coverage is part of that

codecov.yml Outdated Show resolved Hide resolved
Copy link
Member

@CharlieC3 CharlieC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me! :shipit: I don't necessarily like that we have to duplicate more workflow logic. I'm not suggesting we do anything about it right now, but eventually I would like this project to migrate to the "component" workflows.

@hugocaillard
Copy link
Collaborator Author

Thanks @CharlieC3
Indeed, switching to the "new" CI should be a Q4 focus

@hugocaillard hugocaillard merged commit 6a72d54 into develop Nov 10, 2023
17 checks passed
@hugocaillard hugocaillard deleted the ci/add-coverage-step branch November 10, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants