-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests/improve coverage #1246
Merged
Merged
Tests/improve coverage #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugocaillard
commented
Nov 14, 2023
hugocaillard
force-pushed
the
tests/improve-coverage
branch
10 times, most recently
from
November 21, 2023 14:45
fc354e6
to
1d348d8
Compare
hugocaillard
force-pushed
the
tests/improve-coverage
branch
3 times, most recently
from
November 24, 2023 14:39
f63d43d
to
7f605a3
Compare
hugocaillard
force-pushed
the
tests/improve-coverage
branch
from
November 24, 2023 14:40
7f605a3
to
495a603
Compare
hugocaillard
commented
Nov 24, 2023
hugocaillard
commented
Nov 24, 2023
csgui
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The refactoring and deletion of unused code seems to be ok. Code LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is an attempt to clean up some dead code and add some unit tests.