chore: Apply Clippy lints redundant_clone and clear_with_drain

[jbencin]

Description

I've been doing some code cleanup on stacks-core, so I thought I'd try it on this repo also. This repo is already configured to use Clippy, which is great, but by default Clippy does not apply it's "nursery" (experimental) lints. Some of these can be useful and are worth applying. Specifically, I checked the following:

clear_with_drain
collection_is_never_read
needless_collect
iter_with_drain
mutex_integer
set_contains_or_insert
trivial_regex
useless_let_if_seq
unused_rounding
unnecessary_struct_initialization
tuple_array_conversions

Only redundant_clone and clear_with_drain resulted in any changes

Breaking change?

No

Example

This can make the code more clear and improve performance by removing unnecessary function calls. For example, one change I made was:

fn level_to_string(level: &Level) -> String {
    match level {
        Level::Note => blue!("note:").to_string(),
        Level::Warning => yellow!("warning:").to_string(),
        Level::Error => red!("error:").to_string(),
    }
}

to

fn level_to_string(level: &Level) -> String {
    match level {
        Level::Note => blue!("note:"),
        Level::Warning => yellow!("warning:"),
        Level::Error => red!("error:"),
    }
}

Checklist

• Tests added in this PR (if applicable)

[codecov]

Codecov Report

Attention: Patch coverage is 28.57143% with 30 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
components/stacks-network/src/orchestrator.rs	0.00%	5 Missing ⚠️
components/clarity-repl/src/repl/session.rs	66.66%	4 Missing ⚠️
components/clarinet-cli/src/frontend/cli.rs	0.00%	3 Missing ⚠️
components/clarinet-cli/src/lsp/native_bridge.rs	0.00%	2 Missing ⚠️
components/clarinet-deployments/src/onchain/mod.rs	0.00%	2 Missing ⚠️
...ents/clarity-lsp/src/common/requests/completion.rs	0.00%	2 Missing ⚠️
components/clarity-repl/src/repl/debug/dap/mod.rs	0.00%	2 Missing ⚠️
components/stacks-network/src/lib.rs	0.00%	2 Missing ⚠️
components/stacks-rpc-client/src/crypto.rs	0.00%	2 Missing ⚠️
components/clarinet-cli/src/frontend/dap.rs	0.00%	1 Missing ⚠️
... and 5 more

📢 Thoughts on this report? Let us know!

[hugocaillard]

@jbencin thaznks for trying it on Clarinet as well 🙌 💯

What are the benefits/risks of running the experimental lints?
I see that you didn't change any config, so I assume you ran a custom command to get the lints? Should also change a config that would run clippy experimental features so that we don't keep introducing code that break any of these rules?

[jbencin]

What are the benefits/risks of running the experimental lints?

They are just less reliable, so sometimes they miss things, or find false positives. They are still useful, it's just more of a manual process instead of cargo clippy --fix

Should also change a config that would run clippy experimental features so that we don't keep introducing code that break any of these rules?

Personally I wouldn't recommend it because of the false positives. There are still a couple incorrect redundant_clone violations that Clippy finds (I was using Rust/Clippy 1.83)