-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: signers page #1467
feat: signers page #1467
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1467 +/- ##
==========================================
- Coverage 18.59% 17.91% -0.69%
==========================================
Files 443 464 +21
Lines 7523 8023 +500
Branches 1598 1719 +121
==========================================
+ Hits 1399 1437 +38
- Misses 5917 6378 +461
- Partials 207 208 +1 ☔ View full report in Codecov by Sentry. |
de641c7
to
afdc750
Compare
afdc750
to
c7c4211
Compare
c7c4211
to
ae99855
Compare
ae99855
to
9626a03
Compare
The UI looks great! The only thing I saw is that the table doesn't do horizontal scrolling on small viewports |
9626a03
to
a859c27
Compare
f6eafed
to
3fe9c30
Compare
acf264c
to
0bf7320
Compare
Reviewed the threads etc, let's try to simplify this: Also, on the Signer screen , under the Total Stacked, change the / 1.46B circulating supply. to "of 1.46B circulating supply" |
# [1.178.0](v1.177.1...v1.178.0) (2024-05-16) ### Features * signers page ([#1467](#1467)) ([687a883](687a883))
🎉 This PR is included in version 1.178.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
#1454
#1248
NB: The extra text at the bottom of the STX stacked card and the Addresses stacking card are not showing because I have coded it to not show if the token price for STX and BTC are undefined.
This PR changes the figure that we use for total supply on the homepage and signers page @saralab @andresgalante
Home page
Before:
After:
@eugeniadigon Does this look ok. I know you wanted to change this based on the thread in Slack but I wasn't sure what the final decision was on the design
Signers page
Up until this point, we have been using 1.82 B as the total supply of the STX token. However, accoridng to the whitepaper, 1.82B is the predefined future supply for 2050. Thus, I do not think that 1.82B accurately represents the total supply today. Total supply represents the amount of tokens that exist today, that have been minted or mined into existence, whether they are staked/locked/unlocked etc. The tokens exist in some form or fashion and can be accounted for on the blockchain.
Where we are using the hardcoded 1.82 B total supply today we should be using the circulating/liquid supply. Circulating supply is a subset of total supply. It is the amount of tokens that have been minted or mined, minus tokens that are locked and vesting, and that are available to trade. Circulating supply includes staked/stacked tokens, as they can be unstaked/unstacked and traded. As far as I know, there aren't any STX tokens that have not vested already and have not been put into circulation. If we had that data, those tokens + the circulating/liquid supply would give us an accurate figure for total supply.
The circulating supply we get from the liquid supply from pox (unlocked_stx), as well as the unlocked supply from stx_supply (total_liquid_supply_ustx)
Total supply from from stx_supply (total_stx) is hardcoded at 1.82B
% of STX stacked we calculate from pox as current_cycle.stacked_ustx / total_liquid_supply_ustx
% of STX not stacked is 1 - current_cycle.stacked_ustx / total_liquid_supply_ustx
Slack context on my discussion of this with @zone117x and @rafaelcr - https://hiropbc.slack.com/archives/C03TU42NL05/p1715273786154159?thread_ts=1715173202.705129&cid=C03TU42NL05
IMPORTANT: If we change the total supply to circulating supply on the explorer, it will conflict with what coinmarketcap shows. So if we go ahead with this change then we should get in touch with CMC to get it changed there as well
@saralab