-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(svelte): add svelte@^4.0.0
peer dependency option for svelte
plugin (fix #551)
#569
Conversation
|
This branch is running in CodeSandbox. Use the links below to review this PR faster. |
✅ Deploy Preview for histoire-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for histoire-controls ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for histoire-examples-vue3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for histoire-examples-svelte3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@bluwy strong recommend for merging this one in pls as it is unnecessarily causing histoire to look broken for svelte 4 |
I'll try to fix the conflicts and ping a maintainer. Would be great to have a review and some guidance. |
svelte@^4.0.0
peer dependency option for svelte
plugin (fix #551)svelte@^4.0.0
peer dependency option for svelte
plugin (fix #551)
Description
Fixes #551.
I've added version
^4.0.0
for the peer dependency inside thesvelte
histoire plugin to be able to migrate the existing repositories that are using histoire withsvelte
to latest version (^4.0.0).What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).