Use Unsloth FastVisionModel for VLM #7295
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiyouga
reviewed
Mar 13, 2025
| @@ -48,11 +53,14 @@ def load_unsloth_pretrained_model( | |||
| config: "PretrainedConfig", model_args: "ModelArguments" | |||
| ) -> Optional["PreTrainedModel"]: | |||
| r"""Optionally load pretrained model with unsloth. Used in training.""" | |||
| from unsloth import FastLanguageModel # type: ignore | |||
| if is_multimodal(model_args.model_name_or_path): | |||
There was a problem hiding this comment.
How about use FastModel? https://github.com/unslothai/unsloth/blob/main/unsloth/models/loader.py#L722-L726
There was a problem hiding this comment.
I think for LLM, the recommended class to use is FastLanguageModel, which inherits from FastLlamaModel
(https://github.com/unslothai/unsloth/blob/main/unsloth/models/loader.py#L69C25-L69C40, https://colab.research.google.com/github/unslothai/notebooks/blob/main/nb/Llama3.1_(8B)-Alpaca.ipynb)
hiyouga
reviewed
Mar 14, 2025
|
|
||
|
|
||
| def load_unsloth_peft_model( | ||
| config: "PretrainedConfig", model_args: "ModelArguments", is_trainable: bool | ||
| ) -> "PreTrainedModel": | ||
| r"""Load peft model with unsloth. Used in both training and inference.""" | ||
| from unsloth import FastLanguageModel # type: ignore | ||
| if is_multimodal(model_args.model_name_or_path): |
There was a problem hiding this comment.
how about the situation of providing a local path to the model?
There was a problem hiding this comment.
Good point, thanks ! I will check for that ASAP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR propose to use unsloth
FastVisionModelinstead ofFastLanguageModelfor multimodal model.