Naïve compilation of refining patterns #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPTK
reviewed
Nov 28, 2024
chengluyu
force-pushed
the
hkmc2-ucs2
branch
from
b652421
to
eeca145
Compare
LPTK
reviewed
Nov 29, 2024
hkmc2/shared/src/main/scala/hkmc2/semantics/ucs/DesugaringBase.scala
Outdated
Show resolved
Hide resolved
LPTK
reviewed
Nov 29, 2024
hkmc2/shared/src/main/scala/hkmc2/semantics/ucs/DesugaringBase.scala
Outdated
Show resolved
Hide resolved
LPTK
reviewed
Nov 29, 2024
hkmc2/shared/src/main/scala/hkmc2/semantics/ucs/DesugaringBase.scala
Outdated
Show resolved
Hide resolved
LPTK
requested changes
Dec 2, 2024
| case S(cls: (ClassSymbol | ModuleSymbol)) => | ||
| raise(ErrorReport(msg"Cannot match ${ctor.describe} as a string prefix" -> ctor.toLoc :: Nil)) | ||
| val kind = cls match { case _: ClassSymbol => "class" case _ => "module" } |
There was a problem hiding this comment.
This should rather use cls.tree.k.
There was a problem hiding this comment.
Thanks. There is a small problem, tree is a val defined on both ClassSymbol and ModuleSymbol independently (no base class has such a field), so I can't simply access it with cls.tree. Do you have any suggestions?
There was a problem hiding this comment.
Oh, I think you can just declare an abstract val in MemberSymbol.
There was a problem hiding this comment.
If that's the case, I need to implement tree: Tree in BlockMemberSymbol, TermSymbol, TypeAliasSymbol, and TopLevelSymbol. Sorry, I need more guidance.
hkmc2/shared/src/main/scala/hkmc2/semantics/ucs/DesugaringBase.scala
Outdated
Show resolved
Hide resolved
hkmc2/shared/src/main/scala/hkmc2/semantics/ucs/DesugaringBase.scala
Outdated
Show resolved
Hide resolved
hkmc2/shared/src/main/scala/hkmc2/semantics/ucs/DesugaringBase.scala
Outdated
Show resolved
Hide resolved
hkmc2/shared/src/main/scala/hkmc2/semantics/ucs/DesugaringBase.scala
Outdated
Show resolved
Hide resolved
hkmc2/shared/src/main/scala/hkmc2/semantics/ucs/Translator.scala
Outdated
Show resolved
Hide resolved
LPTK
reviewed
Dec 2, 2024
hkmc2/shared/src/main/scala/hkmc2/semantics/ucs/Translator.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.