Sketcher: Fix double click of wire and remove selection that was not … #237
Annotations
1 error and 30 warnings
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L79
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L80
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L145
Use int16_t/int64_t/etc, rather than the C type long [runtime/int] [4]
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L147
Using C-style cast. Use static_cast<uint32_t>(...) instead [readability/casting] [4]
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L567
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L694
Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L697
Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L824
Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L831
Using deprecated casting style. Use static_cast<float>(...) instead [readability/casting] [4]
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L831
Using C-style cast. Use static_cast<float>(...) instead [readability/casting] [4]
|
build/_deps/fmt-src/include/fmt/core.h#L971
fmt::detail::iterator_buffer has dtor but not copy-ctor, copy-assignment [-Wclazy-rule-of-three]
|
build/_deps/fmt-src/include/fmt/core.h#L1002
fmt::detail::iterator_buffer has dtor but not copy-ctor, copy-assignment [-Wclazy-rule-of-three]
|
build/_deps/fmt-src/include/fmt/core.h#L2095
Returning a void expression [-Wclazy-returning-void-expression]
|
build/_deps/fmt-src/include/fmt/core.h#L2197
fmt::detail::specs_setter has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
|
build/_deps/fmt-src/include/fmt/core.h#L2233
fmt::detail::dynamic_specs_handler has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
|
build/_deps/fmt-src/include/fmt/core.h#L3126
Pass small and trivially-copyable type by value (const signed char &) [-Wclazy-function-args-by-value]
|
build/_deps/fmt-src/include/fmt/core.h#L3127
Pass small and trivially-copyable type by value (const unsigned char &) [-Wclazy-function-args-by-value]
|
build/_deps/fmt-src/include/fmt/core.h#L3128
Pass small and trivially-copyable type by value (const short &) [-Wclazy-function-args-by-value]
|
build/_deps/fmt-src/include/fmt/core.h#L3129
Pass small and trivially-copyable type by value (const unsigned short &) [-Wclazy-function-args-by-value]
|
build/_deps/fmt-src/include/fmt/core.h#L3130
Pass small and trivially-copyable type by value (const long &) [-Wclazy-function-args-by-value]
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L134
parameter name 'r' is too short, expected at least 2 characters [readability-identifier-length]
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L135
parameter name 'g' is too short, expected at least 2 characters [readability-identifier-length]
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L135
parameter name 'b' is too short, expected at least 2 characters [readability-identifier-length]
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L145
use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L250
0.7f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L250
floating point literal has suffix 'f', which is not uppercase [readability-uppercase-literal-suffix]
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L250
0.7f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L250
floating point literal has suffix 'f', which is not uppercase [readability-uppercase-literal-suffix]
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L250
0.7f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L250
floating point literal has suffix 'f', which is not uppercase [readability-uppercase-literal-suffix]
|
The logs for this run have expired and are no longer available.
Loading