MeasureGui: Revert temporary measure object creation #238
Annotations
1 error and 30 warnings
|
|
|
src/Mod/Measure/Gui/TaskMeasure.cpp#L47
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
|
src/Mod/Measure/Gui/TaskMeasure.cpp#L236
Add #include <string> for string [build/include_what_you_use] [4]
|
|
src/Mod/Measure/Gui/TaskMeasure.h#L1
No #ifndef header guard found, suggested CPP variable is: SRC_MOD_MEASURE_GUI_TASKMEASURE_H_ [build/header_guard] [5]
|
|
src/Mod/Measure/Gui/TaskMeasure.h#L93
Add #include <vector> for vector<> [build/include_what_you_use] [4]
|
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L79
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L80
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L145
Use int16_t/int64_t/etc, rather than the C type long [runtime/int] [4]
|
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L147
Using C-style cast. Use static_cast<uint32_t>(...) instead [readability/casting] [4]
|
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L567
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
|
|
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L694
Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
|
|
src/Mod/Measure/Gui/TaskMeasure.h#L72
private field '_mDocument' is not used [-Wunused-private-field]
|
|
src/Mod/Measure/Gui/TaskMeasure.h#L73
private field '_mGuiDocument' is not used [-Wunused-private-field]
|
|
build/_deps/fmt-src/include/fmt/core.h#L971
fmt::detail::iterator_buffer has dtor but not copy-ctor, copy-assignment [-Wclazy-rule-of-three]
|
|
build/_deps/fmt-src/include/fmt/core.h#L1002
fmt::detail::iterator_buffer has dtor but not copy-ctor, copy-assignment [-Wclazy-rule-of-three]
|
|
build/_deps/fmt-src/include/fmt/core.h#L2095
Returning a void expression [-Wclazy-returning-void-expression]
|
|
build/_deps/fmt-src/include/fmt/core.h#L2197
fmt::detail::specs_setter has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
|
|
build/_deps/fmt-src/include/fmt/core.h#L2233
fmt::detail::dynamic_specs_handler has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
|
|
build/_deps/fmt-src/include/fmt/core.h#L3126
Pass small and trivially-copyable type by value (const signed char &) [-Wclazy-function-args-by-value]
|
|
build/_deps/fmt-src/include/fmt/core.h#L3127
Pass small and trivially-copyable type by value (const unsigned char &) [-Wclazy-function-args-by-value]
|
|
build/_deps/fmt-src/include/fmt/core.h#L3128
Pass small and trivially-copyable type by value (const short &) [-Wclazy-function-args-by-value]
|
|
src/Mod/Measure/Gui/TaskMeasure.cpp#L69
'showDelta' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]
|
|
src/Mod/Measure/Gui/TaskMeasure.cpp#L75
'modeSwitch' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]
|
|
src/Mod/Measure/Gui/TaskMeasure.cpp#L89
'valueResult' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]
|
|
src/Mod/Measure/Gui/TaskMeasure.cpp#L95
use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
|
|
src/Mod/Measure/Gui/TaskMeasure.cpp#L96
10 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
|
src/Mod/Measure/Gui/TaskMeasure.cpp#L159
do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]
|
|
src/Mod/Measure/Gui/TaskMeasure.cpp#L160
redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
|
|
src/Mod/Measure/Gui/TaskMeasure.cpp#L191
do not use C-style cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-cstyle-cast]
|
|
src/Mod/Measure/Gui/TaskMeasure.cpp#L202
do not use C-style cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-cstyle-cast]
|
|
src/Mod/Measure/Gui/TaskMeasure.cpp#L234
do not call c-style vararg functions [cppcoreguidelines-pro-type-vararg]
|
The logs for this run have expired and are no longer available.
Loading