MeasureGui: Add additional type check in ensureGroup #240
Annotations
1 error and 24 warnings
|
src/Mod/Measure/Gui/TaskMeasure.cpp#L47
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
src/Mod/Measure/Gui/TaskMeasure.cpp#L221
Add #include <string> for string [build/include_what_you_use] [4]
|
src/Mod/Measure/Gui/TaskMeasure.h#L22
#ifndef header guard has wrong style, please use: SRC_MOD_MEASURE_GUI_TASKMEASURE_H_ [build/header_guard] [5]
|
src/Mod/Measure/Gui/TaskMeasure.h#L101
#endif line should be "#endif // SRC_MOD_MEASURE_GUI_TASKMEASURE_H_" [build/header_guard] [5]
|
build/_deps/fmt-src/include/fmt/core.h#L971
fmt::detail::iterator_buffer has dtor but not copy-ctor, copy-assignment [-Wclazy-rule-of-three]
|
build/_deps/fmt-src/include/fmt/core.h#L1002
fmt::detail::iterator_buffer has dtor but not copy-ctor, copy-assignment [-Wclazy-rule-of-three]
|
build/_deps/fmt-src/include/fmt/core.h#L2095
Returning a void expression [-Wclazy-returning-void-expression]
|
build/_deps/fmt-src/include/fmt/core.h#L2197
fmt::detail::specs_setter has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
|
build/_deps/fmt-src/include/fmt/core.h#L2233
fmt::detail::dynamic_specs_handler has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
|
build/_deps/fmt-src/include/fmt/core.h#L3126
Pass small and trivially-copyable type by value (const signed char &) [-Wclazy-function-args-by-value]
|
build/_deps/fmt-src/include/fmt/core.h#L3127
Pass small and trivially-copyable type by value (const unsigned char &) [-Wclazy-function-args-by-value]
|
build/_deps/fmt-src/include/fmt/core.h#L3128
Pass small and trivially-copyable type by value (const short &) [-Wclazy-function-args-by-value]
|
build/_deps/fmt-src/include/fmt/core.h#L3129
Pass small and trivially-copyable type by value (const unsigned short &) [-Wclazy-function-args-by-value]
|
build/_deps/fmt-src/include/fmt/core.h#L3130
Pass small and trivially-copyable type by value (const long &) [-Wclazy-function-args-by-value]
|
src/Mod/Measure/Gui/TaskMeasure.cpp#L69
'showDelta' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]
|
src/Mod/Measure/Gui/TaskMeasure.cpp#L75
'modeSwitch' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]
|
src/Mod/Measure/Gui/TaskMeasure.cpp#L89
'valueResult' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]
|
src/Mod/Measure/Gui/TaskMeasure.cpp#L95
use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
|
src/Mod/Measure/Gui/TaskMeasure.cpp#L96
10 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
src/Mod/Measure/Gui/TaskMeasure.cpp#L219
do not call c-style vararg functions [cppcoreguidelines-pro-type-vararg]
|
src/Mod/Measure/Gui/TaskMeasure.cpp#L224
variable name 's' is too short, expected at least 2 characters [readability-identifier-length]
|
src/Mod/Measure/Gui/TaskMeasure.cpp#L234
the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
|
|
src/Mod/Measure/Gui/TaskMeasure.cpp#L260
implicit conversion 'Measure::MeasureBase *' -> bool [readability-implicit-bool-conversion]
|
The logs for this run have expired and are no longer available.
Loading