Bug/ex UI 2743 check application task not completing #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* case view not fully expended * yarn audit * update failing test * version update --------- Co-authored-by: RiteshHMCTS <[email protected]>
Edit to deletion of user_task and session storage constants
…om/hmcts/ccd-case-ui-toolkit into bug/EXUI-2668-task-auto-completing
Fix sonar coverage
* Add check for external user to disable hyperlink on case history * Fix unit tests * Update to prerelease ver name * Remove console.log * add test for external user not being shown hyperlink * set to old sonar version * change version number --------- Co-authored-by: RiteshHMCTS <[email protected]>
Add taskEventCompletionInfo when client context added via payload
…check-application-task-not-completing
RiteshHMCTS
previously approved these changes
Feb 3, 2025
andywilkinshmcts
previously approved these changes
Feb 4, 2025
| @@ -128,6 +133,7 @@ export class CaseEditComponent implements OnInit, OnDestroy { | |||
| this.route.queryParams.subscribe((params: Params) => { | |||
| this.navigationOrigin = params[CaseEditComponent.ORIGIN_QUERY_PARAM]; | |||
| }); | |||
| removeTaskFromClientContext(this.sessionStorageService); | |||
There was a problem hiding this comment.
Are you sure this is OK in the scenario where we start a task from a next steps link in a task?
There was a problem hiding this comment.
Yes, will remove this as is not needed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/EXUI-2743
Change description
Stop tasks relevant to events being overwritten when valid to the event
Does this PR introduce a breaking change? (check one with "x")