EXUI-2640 - Add exclusion list code for doc store url #1867
+96
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StoneBenHMCTS
previously approved these changes
Feb 11, 2025
RiteshHMCTS
previously approved these changes
Feb 11, 2025
MunishSharmaHMCTS
previously approved these changes
Feb 11, 2025
andywilkinshmcts
requested changes
Feb 12, 2025
| let docStoreUrl = ''; | ||
| this.caseNotifierService.caseView.subscribe((caseDetails) => { | ||
| const caseType = caseDetails.case_type.id; | ||
| const documentSecureModeCaseTypeExclusions = this.appConfig.getDocumentSecureModeCaseTypeExclusions().split(','); |
There was a problem hiding this comment.
Let's be extra cautious and use
this.appConfig.getDocumentSecureModeCaseTypeExclusions()?.split(',');
and
const isDocumentOnExclusionList = documentSecureModeCaseTypeExclusions?.includes(caseType);
There was a problem hiding this comment.
Added the additional '?'
Josh-HMCTS
dismissed stale reviews from MunishSharmaHMCTS, RiteshHMCTS, and StoneBenHMCTS
via
e1261ce
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/EXUI-2640
Change description
Add exclusion list code to docstore getURL()
Does this PR introduce a breaking change? (check one with "x")