NFDIV-3985 Send letter to applicant when new paper case is created #4141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CCD diff reportNo change |
...main/java/uk/gov/hmcts/divorce/document/content/PaperApplicationReceivedTemplateContent.java
Outdated
Show resolved
Hide resolved
CCD diff reportNo change |
DelythJustice
previously approved these changes
Nov 7, 2024
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically closed because it has been stalled for 2 days with no activity. |
CCD diff reportNo change |
1 similar comment
CCD diff reportNo change |
CCD diff reportNo change |
CCD diff reportNo change |
CCD diff reportFixedLists/DocumentType.json
FixedLists/ConfidentialDocumentsReceived.json
|
CCD diff reportFixedLists/DocumentType.json
FixedLists/ConfidentialDocumentsReceived.json
|
adamg-hmcts
reviewed
Jan 28, 2025
| @@ -69,10 +78,35 @@ private Document generateDocument(final long caseId, | |||
| final Applicant applicant, | |||
| final CaseData caseData) { | |||
|
|
|||
| boolean isApplicant1 = applicant == caseData.getApplicant1(); | |||
There was a problem hiding this comment.
It might be fine as it is, but I think we'd usually use .equals() here to do the check based on object equality (values of the instance vars due to the Lombok Data annotation) rather than references in memory?
adamg-hmcts
previously approved these changes
Jan 28, 2025
CCD diff reportFixedLists/DocumentType.json
FixedLists/ConfidentialDocumentsReceived.json
|
adamg-hmcts
previously approved these changes
Jan 28, 2025
CCD diff reportFixedLists/DocumentType.json
FixedLists/ConfidentialDocumentsReceived.json
|
CCD diff reportFixedLists/DocumentType.json
FixedLists/ConfidentialDocumentsReceived.json
|
CCD diff reportFixedLists/DocumentType.json
FixedLists/ConfidentialDocumentsReceived.json
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
When a new paper case is created via the bulk scanning process, a letter must be sent to the applicant confirming the receipt of application.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/NFDIV-3985