Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFDIV-4344: Return error when applicants confirm information not corr… #4317

Closed
wants to merge 3 commits into from

Conversation

FaisalMoJ
Copy link
Contributor

…ect without reason

Change description

Enter a description.

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/NFDIV-

Pull request checklist

Before raising

  • tests have been updated / new tests has been added (if needed)
  • README and other documentation has been updated / added (if needed)

Before merging

  • this ticket been reviewed by QA
  • the user story been signed off by the PO

Note: Bug fixes, dependency updates and technical tasks do not directly impact the user experience and can be merged without QA and PO review.

Copy link

CCD diff report

No change

Copy link

CCD diff report

No change

@@ -103,6 +103,17 @@ public AboutToStartOrSubmitResponse<CaseData, State> aboutToSubmit(final CaseDet
ConditionalOrderQuestions app2Questions = data.getConditionalOrder().getConditionalOrderApplicant2Questions();
ConditionalOrderQuestions appQuestions = isApplicant1 ? app1Questions : app2Questions;

if (appQuestions.getConfirmInformationStillCorrect() != YES && isEmpty(appQuestions.getReasonInformationNotCorrect())) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like sols also use this event to submit the CO - do you know if they get chance to answer the same question? If not, validation will fail each time. Might be worth us having sol test scenarios for Elis

adamg-hmcts
adamg-hmcts previously approved these changes Feb 11, 2025
Copy link

CCD diff report

No change

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 24, 2025
Copy link

This issue has been automatically closed because it has been stalled for 2 days with no activity.

@github-actions github-actions bot closed this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants