Allow sending and receiving messages over the same UDP socket #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, sorry @nsowen ! |
hoijui
reviewed
Dec 30, 2024
| final Transport transport) | ||
| { | ||
| if (transport == null) { | ||
| throw new IllegalStateException( |
There was a problem hiding this comment.
Would a NullPointerException not be more appropriate?
| @@ -97,6 +121,11 @@ public OSCPortInBuilder setNetworkProtocol(final NetworkProtocol protocol) { | |||
| return this; | |||
| } | |||
|
|
|||
| public OSCPortInBuilder setTransport(final Transport networkTransport) { | |||
| transport = networkTransport; | |||
There was a problem hiding this comment.
No must, and I see it is the same in the other methods, which is probably why you did it this way, but I' rather do this as this.transport = transport;, vs choosing arbitrary different names for the two variables.
As said.. leaving it this way is totally fine too.
| @@ -74,4 +98,9 @@ public OSCPortOutBuilder setNetworkProtocol(final NetworkProtocol protocol) { | |||
| networkProtocol = protocol; | |||
| return this; | |||
| } | |||
|
|
|||
| public OSCPortOutBuilder setTransport(final Transport networkTransport) { | |||
| transport = networkTransport; | |||
|
looking good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extension addresses the following issue: #40
That allows bi-directional communication to my Behringer X32 console. Explanation:
With the original implementation, it was of couse possible to use the same input UDP port as the output UDP port, but unfortunately, at least on OSX, it is not possible to create two UDP sockets for sending and receiving on the same port. Therefore I extended the OSCPortOut to accept a "Transport" object in its constructor, which can be retrieved from the OSCPortIn object. Additionally, UDPTransport had to be changed to use two ByteBuffers, one for sending, the other one for receiving. Otherwise we will corrupt receive/response data on the fly. This should not make any issues, as the
var out = new OSCPortOut(new OSCSerializerAndParserBuilder(), new InetSocketAddress("x32-ip", 10023));var in = new OSCPortIn(out.getTransport());in.startListening();out.send(new OSCMessage("/info"));At least this PR works for me since for a few months now. Hope it will meet the quality standards. Please let me know!