-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Drop pillow as a required dependency #1365
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1365 +/- ##
==========================================
- Coverage 88.53% 88.51% -0.02%
==========================================
Files 93 93
Lines 18744 18750 +6
==========================================
+ Hits 16595 16597 +2
- Misses 2149 2153 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. Happy to relax that requirement, as long as we clearly announce the change in the release notes. Thanks!
[skip ci]
@amaloney note to look at dropping pillow or defer importing for now
|
I am not completely sure we should drop it, but we should at least postpone the import until it is needed.