Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh!: Deprecate the streamz interface in holoviews.streams #6490

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jan 15, 2025

The streaming notebook has been ignored for some time, and the author of streamz has mostly retired it:

image

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.75%. Comparing base (b66153a) to head (a43d0c8).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
holoviews/streams.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6490      +/-   ##
==========================================
- Coverage   88.76%   88.75%   -0.01%     
==========================================
  Files         323      323              
  Lines       68681    68699      +18     
==========================================
+ Hits        60963    60977      +14     
- Misses       7718     7722       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro requested a review from philippjfr January 15, 2025 08:19
@maximlt
Copy link
Member

maximlt commented Jan 17, 2025

Can some explanation be provided to the PR text on Github?

@maximlt
Copy link
Member

maximlt commented Jan 17, 2025

To expand a little bit:

The streaming notebook has been ignored for some time

This means the notebook was no longer tested on the CI.

the author of streamz has mostly retired it

This links to a Google Doc where Martin Durant, streamz's author, provides a list of all his OSS contributions/projects with their status.


streamz has about 20k downloads/month. Not super low but indeed much lower than some other projects Martin takes care of (e.g. fsspec).

image

This means hvplot.streamz also has to be deprecated.

doc/user_guide/index.rst Show resolved Hide resolved
examples/user_guide/16-Streaming_Data.ipynb Show resolved Hide resolved
pixi.toml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants