-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move plot widget to bottom #1199
Conversation
bea5347
to
1c308c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't exactly know why but it doesn't fit very well in a notebook output cell. Do you interact with the explorer always as an app? I'd guess the explorer is more used in a notebook context.
When served as an app the plot occupies the whole space and the widget box looks a little alone centered down there.
What alternative do we have? We could maybe dynamically create a new tab populated with the widget box? Or add it below the groupby multiselect?
A floating pane or built into Bokeh's toolbar if ever possible like for HoloNote eventually. |
Oh I suppose we could do |
643018a
to
58b4ece
Compare
Another thing we need to fix is the default |
), | ||
sizing_mode='stretch_both' | ||
sizing_mode='stretch_width', | ||
height=600 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
min_height
unfortunately did not work for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The explorer will look much better with this change when there are multiple widgets!
Shall we merge? |
Yes, I was waiting for the tests to pass. |
Builds on top of #1198 for more screen space for the plot and partially addresses #1190