ci: Fix failing CI #1452
Merged
ci: Fix failing CI #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxbro
commented
Oct 31, 2024
| @@ -150,7 +150,7 @@ jobs: | |||
| matrix: ${{ fromJson(needs.setup.outputs.matrix) }} | |||
| defaults: | |||
| run: | |||
| shell: bash -l {0} | |||
| shell: bash -e {0} | |||
There was a problem hiding this comment.
There is no need to load the settings file (-l), like .bashrc which could pollute the PATH.
Though it is important to exit if one command fails (-e).
| run: pip install -v --prefer-binary -e '.[tests, examples-tests, geo, hvdev, hvdev-geo, dev-extras]' | ||
| - name: pip list | ||
| run: pip list | ||
| run: python -m pip install -v --prefer-binary -e '.[tests, examples-tests, geo, hvdev, hvdev-geo, dev-extras]' |
There was a problem hiding this comment.
Good practice to call python -m pip, see https://pip.pypa.io/en/stable/cli/pip_install/.
| run: python -m pip install -v --prefer-binary -e '.[tests, examples-tests, geo, hvdev, hvdev-geo, dev-extras]' | ||
| - name: python version and pip list | ||
| run: | | ||
| python --version --version |
There was a problem hiding this comment.
Though, it is available with setup-python.
You can revert it if you want to.
maximlt
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See failing test here: https://github.com/holoviz/hvplot/actions/runs/11600853910/job/32302285188