Fix multi-level indirection in Parameters access #840
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started looking at
.param
and noticed this really bizarre (and pointless) double indirection when accessing variables on theParameters
object. There's a bunch of cases where instead of accessing methods directly on theParameters
object we go through this two-level indirect attribute access that just to get back to the same object, i.e.self_.self_or_cls.param._TRIGGER
simplifies to justself_._TRIGGER
.In fact this is so silly that fixing it gives a 10% performance boost for a bunch of common operations: