Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wirelesstag unique_id to use uuid instead of tag_id #104394

Merged
merged 12 commits into from
Nov 30, 2023

Conversation

sergeymaysak
Copy link
Contributor

@sergeymaysak sergeymaysak commented Nov 22, 2023

Proposed change

This is fix for the issue 97736

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot marked this pull request as draft November 23, 2023 08:14
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@MartinHjelmare MartinHjelmare changed the title Fixed unique_id to use of uuid instead of tag_id. Fix wirelesstag unique_id to use uuid instead of tag_id Nov 23, 2023
@sergeymaysak sergeymaysak marked this pull request as ready for review November 23, 2023 11:16
@home-assistant home-assistant bot requested a review from frenck November 23, 2023 11:17
@sergeymaysak sergeymaysak marked this pull request as draft November 26, 2023 10:14
@sergeymaysak sergeymaysak marked this pull request as ready for review November 26, 2023 10:15
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 27, 2023
@frenck
Copy link
Member

frenck commented Nov 29, 2023

@sergeymaysak There is no need to constantly merge dev into this PR (unless there is a conflict or a long time has passed). This is now effectively blocking merging and wasting unneeded CI resources. Let's do it a little less 😉

@sergeymaysak
Copy link
Contributor Author

@sergeymaysak There is no need to constantly merge dev into this PR (unless there is a conflict or a long time has passed). This is now effectively blocking merging and wasting unneeded CI resources. Let's do it a little less 😉

Sure, no prob )

homeassistant/components/wirelesstag/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/wirelesstag/__init__.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 29, 2023 13:06
@sergeymaysak sergeymaysak marked this pull request as ready for review November 29, 2023 17:41
@home-assistant home-assistant bot requested a review from edenhaus November 29, 2023 17:41
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sergeymaysak 👍

@frenck frenck added this to the 2023.12.0 milestone Nov 30, 2023
@frenck frenck dismissed their stale review November 30, 2023 11:14

Comments addressed

@edenhaus edenhaus merged commit 1ab9357 into home-assistant:dev Nov 30, 2023
@sergeymaysak sergeymaysak deleted the tags_unique_id_fix branch November 30, 2023 11:22
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comment in a new PR. Thanks!

frenck pushed a commit that referenced this pull request Nov 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix by-code-owner cherry-picked cla-signed integration: wirelesstag Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wirelesstags does not produce uinique IDs and uses wrong "Id" to produce them
4 participants