Add pglab integration #109725
Add pglab integration #109725
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi @pgaraventa,@pglab-electronics
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Hi @pgaraventa,@pglab-electronics
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
There was a problem hiding this comment.
Hi @pgaraventa
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
There was a problem hiding this comment.
Hi @pgaraventa
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
(Close+open to retrigger CI) |
|
If you need some help getting this PR over the finish line, please feel free to contact me on Discord, I'm @emontnemery there. |
|
@pglab-electronics looking at your homepage it seems the devices are not for sale and there's also no active DIY community building their own devices. We typically require at least one of these criteria to be fulfilled before adding an integration to the Home Assistant Core repo. Until then, a custom integration installable via HACS might be a better fit. |
PG LAB Electronics S.r.l.s. VAT 02950190997 REA N. GE - 522309 is a new startup based in Chiavari, Italy. The devices (E-BOARD, E-RELAY) should be in sale soon. I'm in phase to update the web site adding online selling. At this moment, who is interested can contact me directly. I sent a private message over Discord. I'm happy to have a chat to better understand how to finalize this patch. |
…/unsubscribe to mqtt entity topic and to register/deregister the status update callback
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
Please leave the pull request open... still waiting for review. |
| if not await mqtt.async_wait_for_mqtt_client(hass): | ||
| LOGGER.error("MQTT integration is not available") | ||
| return False |
There was a problem hiding this comment.
Why was this check added, async_wait_for_mqtt_client is already called from async_setup_entry?
There was a problem hiding this comment.
I had problem during git commit with the automatic check. I implemented as the new "qbus" integration.
There was a problem hiding this comment.
Not really sure why... But I don't have anymore problem why the quality checker. I removed the extra mqtt check.
Breaking change
Proposed change
Add pglab integration. The integration allows to interact with PG LAB Electronics devices over MQTT.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: