Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce scope of diagnostics tests for rtsp_to_webrtc to not depend on global state #115422

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

allenporter
Copy link
Contributor

Proposed change

Remove the part of the test that asserts on global counters that would fail if run multiple times. The intent of the test is to verify that diagnostics are working end to end and so its fine to not assert on the lower level counter details of the diagnostics returned by the rtsp_to_webrtc.

Old behavior:

$ pip3 install pytest-repeat
$ py.test --count=2 tests/components/rtsp_to_webrtc 
...
FAILED tests/components/rtsp_to_webrtc/test_diagnostics.py::test_entry_diagnostics[2-2] - AssertionError: assert {'discovery':... 'webrtc': {}} == {'discovery':... 'webrtc': {}}
...

New behavior:

$  py.test --count=2 tests/components/rtsp_to_webrtc 
...
      38 passed

Reverts #115398 which was not needed.

This test was previously observed as flaky:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@jbouwh
Copy link
Contributor

jbouwh commented Apr 11, 2024

I have set out #115426 in the hope to reproduce the previous error.
In a previous run:
https://github.com/home-assistant/core/actions/runs/8638995509/job/23692070713?pr=110950

Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this will be more resilent,
Thnx @allenporter 👍

@jbouwh
Copy link
Contributor

jbouwh commented Apr 11, 2024

Thnx!

@jbouwh jbouwh merged commit 6c1bc2a into home-assistant:dev Apr 11, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants