-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add audio transport direction to WebRTCClientConfiguration #127851
base: dev
Are you sure you want to change the base?
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@sdb9696 Will this also allow for 2-way audio on cameras with a RTSP stream that have a RTSP backchannel? Does the camera entity need to specify if that particular cam supports 2-way audio, or is this info automatically obtained from the stream? |
Hey @starkillerOG, I haven't tested it yet but it should work with RTSP back channel if the component doing the conversion supports it. Yes the integration has to specify that it supports 2-way via the |
Proposed change
Add audio transport direction to WebRTCClientConfiguration to enable two way audio.
Goes with Front end PR 22239
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: