Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add powerfox integration #131640

Draft
wants to merge 17 commits into
base: dev
Choose a base branch
from

Conversation

klaasnicolaas
Copy link
Member

@klaasnicolaas klaasnicolaas commented Nov 26, 2024

Proposed change

This PR will add the Powerfox integration to get (currently only) your power and water meter data.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@frenck frenck marked this pull request as draft November 26, 2024 17:48
@frenck
Copy link
Member

frenck commented Nov 26, 2024

Marked draft, as there are CI errors.

@klaasnicolaas klaasnicolaas marked this pull request as ready for review November 26, 2024 19:22
homeassistant/components/powerfox/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/powerfox/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/powerfox/sensor.py Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft November 27, 2024 15:51
docs-troubleshooting: todo
docs-use-cases: done
dynamic-devices: todo
entity-category: done
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this one be exempt since it does not have any non-primary entities?

Copy link
Member Author

@klaasnicolaas klaasnicolaas Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on whether it concerns only the classification of non-primary entities or the use of entityCategory in general, with the Autarco integration it's also accepted even though it has no non-primary entities 🤷🏻‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants