Palazzetti power control #131833
Open
Palazzetti power control #131833
+206
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
zweckj
suggested changes
Nov 28, 2024
| self, | ||
| coordinator: PalazzettiDataUpdateCoordinator, | ||
| description: PalazzettiNumberEntityDescription, | ||
| entry_id: str, |
Comment on lines
25
to
26
| MIN_POWER = 1 | ||
| MAX_POWER = 5 |
There was a problem hiding this comment.
why set those as const if they are only used once anyways?
Comment on lines
48
to
59
| config_entry.runtime_data, | ||
| PalazzettiNumberEntityDescription( | ||
| key="combustion_power", | ||
| translation_key="combustion_power", | ||
| device_class=NumberDeviceClass.POWER_FACTOR, | ||
| native_min_value=MIN_POWER, | ||
| native_max_value=MAX_POWER, | ||
| native_step=1, | ||
| value_property="power_mode", | ||
| update_fn=client.set_power_mode, | ||
| ), | ||
| config_entry.entry_id, |
There was a problem hiding this comment.
imo either you are planning for more entities here, in which case you should still make a list and iterate, or you might just as well hardcode it into the entity definition directly
| {ATTR_ENTITY_ID: ENTITY_ID, "value": 1}, | ||
| blocking=True, | ||
| ) | ||
| mock_palazzetti_client.set_power_mode.assert_called_once_with(1) |
There was a problem hiding this comment.
maybe verify that the value did indeed change
There was a problem hiding this comment.
I don't think that I can do that. The client API is fully mocked and does not update its state.
zweckj
reviewed
Nov 29, 2024
Comment on lines
26
to
31
| @dataclass(frozen=True, kw_only=True) | ||
| class PalazzettiNumberEntityDescription(NumberEntityDescription): | ||
| """Describes Palazzetti number entity.""" | ||
|
|
||
| value_property: str | ||
| update_fn: Callable[[int], Coroutine[Any, Any, None]] |
There was a problem hiding this comment.
Suggested change
| @dataclass(frozen=True, kw_only=True) | |
| class PalazzettiNumberEntityDescription(NumberEntityDescription): | |
| """Describes Palazzetti number entity.""" | |
| value_property: str | |
| update_fn: Callable[[int], Coroutine[Any, Any, None]] |
unused now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add a number entity to Palazzetti to control the "combustion power" of the stove.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: