-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tip connected detection to IronOS #131946
Open
tr4nt0r
wants to merge
8
commits into
home-assistant:dev
Choose a base branch
from
tr4nt0r:iron_os_tip_connected
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
zweckj
reviewed
Nov 30, 2024
zweckj
approved these changes
Dec 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
frenck
added
the
smash
Indicator this PR is close to finish for merging or closing
label
Dec 1, 2024
tr4nt0r
force-pushed
the
iron_os_tip_connected
branch
from
December 2, 2024 11:49
43a39a0
to
4f3d8a5
Compare
tr4nt0r
changed the title
Add binary platform and tip connected detection to IronOS
Add tip connected detection to IronOS
Dec 2, 2024
zweckj
reviewed
Dec 2, 2024
zweckj
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that, it's just a lot more focused now 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
by-code-owner
cla-signed
has-tests
integration: iron_os
new-feature
new-platform
Quality Scale: No score
smash
Indicator this PR is close to finish for merging or closing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds detection if soldering tip is connected and sets the state of sensors that give invalid values when no tip is connected to unknown
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: