-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark Vogel's MotionMount integration as Bronze on the quality scale #137012
base: dev
Are you sure you want to change the base?
Conversation
18c5c7c
to
e9009c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also add the rest of the quality scale
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
b768c66
to
5120dca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and the rest too please
Are all your concerns handled? Shall I open it for review again? |
Proposed change
This PR marks the integration has having reached Bronze
Type of change
Additional information
Bronze
action-setup
- Service actions are registered in async_setup - Integration doesn't have actionsappropriate-polling
- If it's a polling integration, set an appropriate polling interval - https://github.com/home-assistant/core/blob/84ae476b678fa0e593e83a01db16359ca021189b/homeassistant/components/motionmount/select.py#L19C1-L19C38brands
- Has branding assets available for the integrationcommon-modules
- Place common patterns in common modules - https://github.com/home-assistant/core/blob/dev/homeassistant/components/motionmount/entity.pyconfig-flow-test-coverage
- Full test coverage for the config flowconfig-flow
- Integration needs to be able to be set up via the UIdata_description
to give context to fields -core/homeassistant/components/motionmount/strings.json
Line 15 in df166d1
ConfigEntry.data
andConfigEntry.options
correctlydependency-transparency
- Dependency transparency - https://github.com/vogelsproducts/python-MotionMountdocs-actions
- The documentation describes the provided service actions that can be used - The integration doesn't have actionsdocs-high-level-description
- The documentation includes a high-level description of the integration brand, product, or service - https://www.home-assistant.io/integrations/motionmount/docs-installation-instructions
- The documentation provides step-by-step installation instructions for the integration, including, if needed, prerequisites - https://www.home-assistant.io/integrations/motionmount/#configurationdocs-removal-instructions
- The documentation provides removal instructions - https://www.home-assistant.io/integrations/motionmount/#removing-the-integrationentity-event-setup
- Entities event setup - The integration doesn't register eventsentity-unique-id
- Entities have a unique ID -core/homeassistant/components/motionmount/number.py
Line 47 in 84ae476
has-entity-name
- Entities use has_entity_name = True -core/homeassistant/components/motionmount/entity.py
Line 23 in 84ae476
runtime-data
- Use ConfigEntry.runtime_data to store runtime data -core/homeassistant/components/motionmount/__init__.py
Line 70 in 84ae476
test-before-configure
- Test a connection in the config flow -core/homeassistant/components/motionmount/config_flow.py
Line 54 in 84ae476
test-before-setup
- Check during integration initialization if we are able to set it up correctly -core/homeassistant/components/motionmount/__init__.py
Line 36 in 84ae476
unique-config-entry
- Don't allow the same device or service to be able to be set up twice -core/homeassistant/components/motionmount/config_flow.py
Line 72 in 84ae476
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: