Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Vogel's MotionMount integration as Bronze on the quality scale #137012

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

RJPoelstra
Copy link
Contributor

@RJPoelstra RJPoelstra commented Jan 31, 2025

Proposed change

This PR marks the integration has having reached Bronze

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Bronze

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • I have followed the [perfect PR recommendations][perfect-pr]
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

  • The [manifest file][manifest-docs] has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Member

@zweckj zweckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add the rest of the quality scale

@home-assistant home-assistant bot marked this pull request as draft February 1, 2025 12:13
@home-assistant
Copy link

home-assistant bot commented Feb 1, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@RJPoelstra RJPoelstra marked this pull request as ready for review February 2, 2025 09:11
@home-assistant home-assistant bot requested a review from zweckj February 2, 2025 09:11
Copy link
Member

@zweckj zweckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and the rest too please

homeassistant/components/motionmount/quality_scale.yaml Outdated Show resolved Hide resolved
homeassistant/components/motionmount/quality_scale.yaml Outdated Show resolved Hide resolved
homeassistant/components/motionmount/quality_scale.yaml Outdated Show resolved Hide resolved
homeassistant/components/motionmount/quality_scale.yaml Outdated Show resolved Hide resolved
homeassistant/components/motionmount/quality_scale.yaml Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft February 3, 2025 19:20
@RJPoelstra RJPoelstra marked this pull request as ready for review February 4, 2025 08:23
@home-assistant home-assistant bot requested a review from zweckj February 4, 2025 08:23
@home-assistant home-assistant bot marked this pull request as draft February 4, 2025 10:08
@RJPoelstra
Copy link
Contributor Author

Are all your concerns handled? Shall I open it for review again?

@RJPoelstra RJPoelstra marked this pull request as ready for review February 4, 2025 12:03
@home-assistant home-assistant bot requested a review from zweckj February 4, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants