Add support for Matter EVSE devicetype #137189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
lboue
changed the title
19 tasks
lboue
changed the title
NoRi2909
reviewed
Feb 4, 2025
NoRi2909
reviewed
Feb 5, 2025
marcelveldt
reviewed
Feb 5, 2025
marcelveldt
reviewed
Feb 5, 2025
marcelveldt
changed the title
marcelveldt
reviewed
Feb 5, 2025
Comment on lines
+152
to
+193
| @pytest.mark.parametrize("node_fixture", ["silabs_evse_charging"]) | ||
| async def test_evse_sensor( | ||
| hass: HomeAssistant, | ||
| matter_client: MagicMock, | ||
| matter_node: MatterNode, | ||
| ) -> None: | ||
| """Test evse sensors.""" | ||
| entity_id = "binary_sensor.evse_charging_status" | ||
| state = hass.states.get(entity_id) | ||
| assert state | ||
| assert state.state == "on" | ||
| # switch to PluggedInDemand state | ||
| set_node_attribute(matter_node, 1, 153, 0, 2) | ||
| await trigger_subscription_callback( | ||
| hass, matter_client, data=(matter_node.node_id, "1/153/0", 2) | ||
| ) | ||
| state = hass.states.get(entity_id) | ||
| assert state | ||
| assert state.state == "off" | ||
|
|
||
| # binary_sensor.evse_plug | ||
| state = hass.states.get("binary_sensor.evse_plug") | ||
| assert state | ||
| assert state.state == "on" | ||
| # switch to NotPluggedIn state | ||
| set_node_attribute(matter_node, 1, 153, 0, 0) | ||
| await trigger_subscription_callback( | ||
| hass, matter_client, data=(matter_node.node_id, "1/153/0", 0) | ||
| ) | ||
| state = hass.states.get(entity_id) | ||
| assert state | ||
| assert state.state == "off" | ||
|
|
||
| # binary_sensor.evse_supply_charging_state | ||
| state = hass.states.get("binary_sensor.evse_supply_charging_state") | ||
| assert state | ||
| assert state.state == "on" | ||
| # switch to Disabled state | ||
| set_node_attribute(matter_node, 1, 153, 0, 0) | ||
| await trigger_subscription_callback( | ||
| hass, matter_client, data=(matter_node.node_id, "1/153/1", 0) | ||
| ) |
There was a problem hiding this comment.
If this is using an existing sensor class that already has tests for the generic behavior, this does not need explicit extra tests and the snapshot testing is sufficient. It doesn't harm either.
Will leave this up to @joostlek
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Support for Matter EVSE - EnergyEvse cluster
Matter 1.3’s energy features enable new energy-centric devices, the first of which is Electric Vehicle Supply Equipment (EVSE).
I was asked to replace the buttons with a switch in the PR#133662.
As discussed with Marcel, the second step would be to create a specific entity for EVSE in Home Assistant for better integration.
Type of change
Additional information
Changes
Add
command_timeout attributeinMatterGenericCommandSwitchclass. This is mandatory forEnergyEvsecommands.Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: