-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for sensors in SwitchBot Cloud #137319
Add tests for sensors in SwitchBot Cloud #137319
Conversation
Hey there @SeraphicRav, @laurence-presland, @Gigatrappeur, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
ef800fc
to
f1998d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could use snapshots for both tests instead?
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
f1998d1
to
1b54fae
Compare
1b54fae
to
2620357
Compare
Tests changed to use snapshots as well as a fixture |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Proposed change
SwitchBot Cloud sensor was not covered by any tests, this PR adds some for Meters.
Presence of these tests would've prevented the mistake fixed by #135985.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: