Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Switch platform and PDU dynamic outlet switches to NUT #141159

Merged
merged 9 commits into from
Mar 23, 2025

Conversation

tdfountain
Copy link
Contributor

@tdfountain tdfountain commented Mar 22, 2025

Proposed change

Add PDU outlet switches. Certain PDUs provide control for individual outlets. This PR adds a switch to HA to call the NUT integration command outlet.X.load.on or outlet.X.load.off to turn on or off an outlet. This PR is related to PR #140179 for the addition of dynamic sensors for outlets and PR #140317 for the addition of dynamic buttons.

IMPORTANT NOTE: This PR is a noteworthy change from the merged PR #139044 and #139656. That pair of PRs added device_action support for these operations and was limited to only two outlets. This PR upgrades from a device_action to a switch and extends to a dynamically specified number of outlets. This change must be merged before the end of the month to avoid becoming a breaking change. If not merged by then, the PR will be updated to a breaking change and the appropriate changes will be documented.

This PR dynamically creates switches. This is based on the number of outlets specified by outlet.count. The switches are only added when outlet.count is specified and the NUT server reports support for the associated commands.

These new switches use translations with translation placeholders in strings.json. The appropriate translation entries have also been provided for icons.json.

New test cases were written to test the Switch platform.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @bdraco, @ollo69, @pestevez, mind taking a look at this pull request as it has been labeled with an integration (nut) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of nut can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign nut Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Co-authored-by: J. Nick Koston <[email protected]>
@bdraco
Copy link
Member

bdraco commented Mar 23, 2025

I think it’s good to go once there is a test verify state_unknown for the missing keys

@bdraco bdraco merged commit 9e86ca2 into home-assistant:dev Mar 23, 2025
34 checks passed
@bdraco
Copy link
Member

bdraco commented Mar 23, 2025

Thanks @tdfountain

@tdfountain tdfountain deleted the add-pdu-dynamic-switches branch March 24, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants