-
-
Notifications
You must be signed in to change notification settings - Fork 33k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Switch platform and PDU dynamic outlet switches to NUT #141159
Merged
bdraco
merged 9 commits into
home-assistant:dev
from
tdfountain:add-pdu-dynamic-switches
Mar 23, 2025
Merged
Add Switch platform and PDU dynamic outlet switches to NUT #141159
bdraco
merged 9 commits into
home-assistant:dev
from
tdfountain:add-pdu-dynamic-switches
Mar 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @bdraco, @ollo69, @pestevez, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
bdraco
reviewed
Mar 22, 2025
bdraco
reviewed
Mar 22, 2025
8 tasks
Co-authored-by: J. Nick Koston <[email protected]>
Co-authored-by: J. Nick Koston <[email protected]>
bdraco
reviewed
Mar 22, 2025
Co-authored-by: J. Nick Koston <[email protected]>
… maxsplit and keeping only first two items
bdraco
reviewed
Mar 23, 2025
bdraco
reviewed
Mar 23, 2025
Co-authored-by: J. Nick Koston <[email protected]>
bdraco
reviewed
Mar 23, 2025
Co-authored-by: J. Nick Koston <[email protected]>
I think it’s good to go once there is a test verify state_unknown for the missing keys |
bdraco
approved these changes
Mar 23, 2025
Thanks @tdfountain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add PDU outlet switches. Certain PDUs provide control for individual outlets. This PR adds a switch to HA to call the NUT integration command outlet.X.load.on or outlet.X.load.off to turn on or off an outlet. This PR is related to PR #140179 for the addition of dynamic sensors for outlets and PR #140317 for the addition of dynamic buttons.
IMPORTANT NOTE: This PR is a noteworthy change from the merged PR #139044 and #139656. That pair of PRs added device_action support for these operations and was limited to only two outlets. This PR upgrades from a device_action to a switch and extends to a dynamically specified number of outlets. This change must be merged before the end of the month to avoid becoming a breaking change. If not merged by then, the PR will be updated to a breaking change and the appropriate changes will be documented.
This PR dynamically creates switches. This is based on the number of outlets specified by outlet.count. The switches are only added when outlet.count is specified and the NUT server reports support for the associated commands.
These new switches use translations with translation placeholders in strings.json. The appropriate translation entries have also been provided for icons.json.
New test cases were written to test the Switch platform.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: