Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for deleting image_upload images in media panel #23086

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented Dec 2, 2024

Proposed change

Allow frontend uploaded images to be deleted via media panel. Currently there is no way to remove them after they are uploaded.

I do think the manage media UI here is pretty poor user experience (can't actually see the images you are choosing for delete), but we might as well re-use what we already have to be consistent and minimize effort.

Needs home-assistant/core#131468

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@marcinbauer85
Copy link

@karwosts could you provide screenshots or a video of your proposition? Thanks!

@karwosts
Copy link
Contributor Author

karwosts commented Dec 2, 2024

It's the same flow as currently exists for local media, looks like this:

imagedelete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants