Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device search to quick bar #23095

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

jpbede
Copy link
Member

@jpbede jpbede commented Dec 2, 2024

Proposed change

Add devices to the quick bar, which is accessible through a shortcut (key D). The click on the device row navigates directly to the device detail page.

WTH: https://community.home-assistant.io/t/wth-is-there-no-quick-bar-for-devices/802310

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@home-assistant home-assistant bot added cla-signed WTH Issues & PRs generated from the "Month of What the Heck?" labels Dec 2, 2024
Copy link
Contributor

@MindFreeze MindFreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a prefix for this mode. Otherwise when you start typing and then delete it with backspace, you are dropped into entities mode unexpectedly

src/dialogs/quick-bar/ha-quick-bar.ts Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft December 2, 2024 16:01
@home-assistant
Copy link

home-assistant bot commented Dec 2, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@jpbede
Copy link
Member Author

jpbede commented Dec 2, 2024

We need a prefix for this mode. Otherwise when you start typing and then delete it with backspace, you are dropped into entities mode unexpectedly

You mean how we do it with the commands?

@MindFreeze
Copy link
Contributor

yes, but a different prefix

@jpbede
Copy link
Member Author

jpbede commented Dec 2, 2024

Added the the # prefix for device. Changed the icon as well. Will update the docs now.

@jpbede jpbede marked this pull request as ready for review December 2, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed WTH Issues & PRs generated from the "Month of What the Heck?"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants