Add automatic retry to stream logs #23098
Merged
+80
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
reviewed
Dec 2, 2024
| @@ -226,6 +226,25 @@ export const fetchHassioLogsFollow = async ( | |||
| signal | |||
| ); | |||
|
|
|||
| export const fetchHassioLogsFollowSkip = async ( | |||
There was a problem hiding this comment.
Why adding a new command instead of adding an option param to the existing fetchHassioLogsFollow command?
There was a problem hiding this comment.
I did it because the skip is more complex and needs the cursor and skip lines as addition parameters. But if you want I can rewrite fetchHassioLogsFollow
bramkragten
reviewed
Dec 2, 2024
| @@ -554,6 +578,13 @@ class ErrorLogCard extends LitElement { | |||
| if (err.name === "AbortError") { | |||
| return; | |||
| } | |||
|
|
|||
| // The stream can fail if the connection is lost or firefox service worker intercept the connection | |||
| if (!retry && streamLogs) { | |||
There was a problem hiding this comment.
This can now also cause an infinite loop I guess? Can we make this check more specific?
There was a problem hiding this comment.
There shoulnd't be. Retry is set to false when the first chunk rendered successfully so we say we are in a healty state again. If it fails again beforehand we show the error.
bramkragten
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: