Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "Increase generic entity row touch target (4): iOS troubles #24224

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

ildar170975
Copy link
Contributor

@ildar170975 ildar170975 commented Feb 13, 2025

Breaking change

Proposed change

This whole story:
FR #18461 -> fix #23894 -> issue #23948 -> fix #23953 -> issue #23971 -> fix #23973 -> issue #24009 -> fix #24002

ended up with a fixed look (colored areas are "active"):
image

Same nice look in Chrome & FF in Win10x64.

But there is an issue #24214 in iOS Companion App & Mac.
I see it in iOS 15.7.x & Mac 10.15.x - both Safari and Chrome.
Names & states are not vertically aligned.
image

After unsuccessful attempts to fix this behaviour in iOS - I think that REVERTING to the old structure (at least for height) is the best option.
Now it looks like
image
Active areas became smaller - as they were before 2025.2.
Imho not a big deal if compared with consequences.

Type of change

  • Dependency upgrade
  • [ x ] Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ildar170975 ildar170975 marked this pull request as ready for review February 13, 2025 14:40
@MindFreeze
Copy link
Contributor

I feel like this should be fixable but don't have an iOS device so I'll leave it to someone with one to review

Copy link
Contributor

@wendevlin wendevlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ildar170975 thanks

@wendevlin wendevlin merged commit d8e3689 into home-assistant:dev Feb 14, 2025
16 checks passed
@ildar170975
Copy link
Contributor Author

feel like this should be fixable

I hope so. And I will keep testing alternatives. Let’s consider this PR as a quick fix until a proper way to fix iOS specificity is found.

@ildar170975 ildar170975 deleted the fix-row-ios branch February 14, 2025 11:28
@silamon
Copy link
Contributor

silamon commented Feb 14, 2025

Consider to use fixes https://github.com/home-assistant/frontend/issues/24214 (without the #) to auto close issues when the pull request is merged. In Github it will link the issue and there's will be a slow underline under fixes when you've done it correctly.

@ildar170975
Copy link
Contributor Author

Consider to use fixes

You are right! Usually do it in cases when I am 100% sure.

boern99 pushed a commit to boern99/ha_frontend that referenced this pull request Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants