-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Fronius documentation for new quality scale rules #36033
base: current
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe changes introduce enhancements to the documentation for the Fronius integration in Home Assistant. Key updates include the addition of new sections on "Supported devices," "Known limitations," and "Troubleshooting." The configuration section has been expanded to clarify the host parameter and the activation of the "Solar API." Furthermore, references to entities have been updated for clarity, particularly concerning battery systems and power metrics, and additional troubleshooting steps have been provided. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
source/_integrations/fronius.markdown (3)
23-40
: Improve markdown formatting in the Supported devices sectionThe content is informative, but the markdown formatting needs improvement:
- Add blank lines around lists (before line 26 and after line 34)
- Add blank lines around the second list (before line 37 and after line 39)
Apply these changes:
## Supported devices + The integration supports all inverters providing the Fronius SolarAPI (JSON) interface of version `v0` or `v1`. This includes among others: - Agilo - Eco [...] - Tauro + Devices connected to those inverters or dataloggers are supported as well. + - Energy meter (Fronius Smart Meter or S0 meter connected to the inverter) - Ohmpilot - Storage +🧰 Tools
🪛 LanguageTool
[duplication] ~32-~32: Possible typo: you repeated a word
Context: ...Eco - Galvo - Gen24 - IG Plus - Primo - Symo - Symo Hybrid - Tauro Devices connected to th...(ENGLISH_WORD_REPEAT_RULE)
🪛 Markdownlint (0.35.0)
26-26: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
37-37: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
109-111
: Fix possessive form in energy dashboard sectionThere's a grammatical error in the energy dashboard section.
Apply this change:
- If no battery is connected to an inverter: Add each inverters `Energy total` entity. + If no battery is connected to an inverter: Add each inverter's `Energy total` entity.🧰 Tools
🪛 LanguageTool
[grammar] ~109-~109: The noun should probably be in the singular form.
Context: ...y is connected to an inverter: Add each invertersEnergy total
entity. - If a battery...(EVERY_EACH_SINGULAR)
134-158
: Fix verb form in troubleshooting headingThe content is excellent, but there's a grammatical error in one heading.
Apply this change:
- ### Can't setup the device + ### Can't set up the deviceOtherwise, the new sections provide valuable information about limitations and troubleshooting steps.
🧰 Tools
🪛 LanguageTool
[grammar] ~140-~140: The word “setup” is a noun. The verb is spelled with a space.
Context: ...odbus/). ## Troubleshooting ### Can’t setup the device - Make sure the device is n...(NOUN_VERB_CONFUSION)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
source/_integrations/fronius.markdown
(3 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/fronius.markdown
[duplication] ~32-~32: Possible typo: you repeated a word
Context: ...Eco - Galvo - Gen24 - IG Plus - Primo - Symo - Symo Hybrid - Tauro Devices connected to th...
(ENGLISH_WORD_REPEAT_RULE)
[typographical] ~104-~104: It seems that a comma is missing.
Context: ...ide more data. When an endpoint is not responding correctly the update interval will increase to 10...
(IF_COMMA)
[grammar] ~109-~109: The noun should probably be in the singular form.
Context: ...y is connected to an inverter: Add each inverters Energy total
entity. - If a battery...
(EVERY_EACH_SINGULAR)
[grammar] ~140-~140: The word “setup” is a noun. The verb is spelled with a space.
Context: ...odbus/). ## Troubleshooting ### Can’t setup the device - Make sure the device is n...
(NOUN_VERB_CONFUSION)
🪛 Markdownlint (0.35.0)
source/_integrations/fronius.markdown
26-26: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
37-37: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
🔇 Additional comments (2)
source/_integrations/fronius.markdown (2)
44-48
: LGTM! Clear prerequisites section
The prerequisites are well-documented, with clear instructions about network setup and Solar API activation requirements.
53-58
: LGTM! Well-structured configuration documentation
The configuration section follows Home Assistant documentation standards and clearly describes the required host parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (4)
source/_integrations/fronius.markdown (4)
23-40
: Improve list formatting for better readability.The content accurately lists supported devices. However, the markdown formatting could be enhanced.
Add blank lines around lists for better readability:
The integration supports all inverters providing the Fronius SolarAPI (JSON) interface of version `v0` or `v1`. This includes among others: - Agilo - Eco - Galvo - Gen24 - IG Plus - Primo - Symo - Symo Hybrid - Tauro Devices connected to those inverters or dataloggers are supported as well. - Energy meter (Fronius Smart Meter or S0 meter connected to the inverter) - Ohmpilot - Storage🧰 Tools
🪛 LanguageTool
[duplication] ~32-~32: Possible typo: you repeated a word
Context: ...Eco - Galvo - Gen24 - IG Plus - Primo - Symo - Symo Hybrid - Tauro Devices connected to th...(ENGLISH_WORD_REPEAT_RULE)
🪛 Markdownlint (0.35.0)
26-26: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
37-37: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
104-104
: Add missing comma for better readability.-When an endpoint is not responding correctly the update interval will increase to 10 minutes +When an endpoint is not responding correctly, the update interval will increase to 10 minutes🧰 Tools
🪛 LanguageTool
[typographical] ~104-~104: It seems that a comma is missing.
Context: ...ide more data. When an endpoint is not responding correctly the update interval will increase to 10...(IF_COMMA)
109-109
: Fix possessive form.-Add each inverters `Energy total` entity +Add each inverter's `Energy total` entity🧰 Tools
🪛 LanguageTool
[grammar] ~109-~109: The noun should probably be in the singular form.
Context: ...y is connected to an inverter: Add each invertersEnergy total
entity. - If a battery...(EVERY_EACH_SINGULAR)
183-183
: Fix verb usage.-Can't setup the device +Can't set up the device🧰 Tools
🪛 LanguageTool
[grammar] ~183-~183: The word “setup” is a noun. The verb is spelled with a space.
Context: ...odbus/). ## Troubleshooting ### Can’t setup the device - Make sure the device is n...(NOUN_VERB_CONFUSION)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
source/_integrations/fronius.markdown
(3 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/fronius.markdown
[duplication] ~32-~32: Possible typo: you repeated a word
Context: ...Eco - Galvo - Gen24 - IG Plus - Primo - Symo - Symo Hybrid - Tauro Devices connected to th...
(ENGLISH_WORD_REPEAT_RULE)
[typographical] ~104-~104: It seems that a comma is missing.
Context: ...ide more data. When an endpoint is not responding correctly the update interval will increase to 10...
(IF_COMMA)
[grammar] ~109-~109: The noun should probably be in the singular form.
Context: ...y is connected to an inverter: Add each inverters Energy total
entity. - If a battery...
(EVERY_EACH_SINGULAR)
[grammar] ~183-~183: The word “setup” is a noun. The verb is spelled with a space.
Context: ...odbus/). ## Troubleshooting ### Can’t setup the device - Make sure the device is n...
(NOUN_VERB_CONFUSION)
🪛 Markdownlint (0.35.0)
source/_integrations/fronius.markdown
26-26: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
37-37: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
🔇 Additional comments (2)
source/_integrations/fronius.markdown (2)
130-171
: LGTM! Well-documented example automation.
The example effectively demonstrates how to create an automation based on solar production thresholds. The YAML is well-structured and includes clear descriptions.
177-201
: LGTM! Comprehensive troubleshooting guide.
The limitations and troubleshooting sections provide clear, actionable information for users encountering common issues.
🧰 Tools
🪛 LanguageTool
[grammar] ~183-~183: The word “setup” is a noun. The verb is spelled with a space.
Context: ...odbus/). ## Troubleshooting ### Can’t setup the device - Make sure the device is n...
(NOUN_VERB_CONFUSION)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (4)
source/_integrations/fronius.markdown (4)
23-40
: Improve formatting and readability of the Supported devices sectionThe content is informative, but there are some formatting improvements needed:
The integration supports all inverters providing the Fronius SolarAPI (JSON) interface of version `v0` or `v1`. This includes among others: +The integration supports all inverters providing the Fronius SolarAPI (JSON) interface of version `v0` or `v1`. This includes, among others: - Agilo - Eco [...] + Devices connected to those inverters or dataloggers are supported as well. - Energy meter (Fronius Smart Meter or S0 meter connected to the inverter)🧰 Tools
🪛 LanguageTool
[uncategorized] ~25-~25: A comma might be missing here.
Context: ...interface of versionv0
orv1
. This includes among others: - Agilo - Eco - Galvo - G...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[duplication] ~32-~32: Possible typo: you repeated a word
Context: ...Eco - Galvo - Gen24 - IG Plus - Primo - Symo - Symo Hybrid - Tauro Devices connected to th...(ENGLISH_WORD_REPEAT_RULE)
🪛 Markdownlint (0.35.0)
26-26: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
37-37: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
109-111
: Fix possessive form in energy dashboard section-Add each inverters `Energy total` entity. +Add each inverter's `Energy total` entity.🧰 Tools
🪛 LanguageTool
[grammar] ~109-~109: The noun should probably be in the singular form.
Context: ...y is connected to an inverter: Add each invertersEnergy total
entity. - If a battery...(EVERY_EACH_SINGULAR)
130-165
: Enhance the automation example documentationWhile the example is well-structured, consider adding:
- A brief explanation of why someone might want to use this automation
- Notes about adjusting the threshold values (1000W and 50W) based on specific needs
175-190
: Fix verb form in troubleshooting section-### Can't setup the device +### Can't set up the deviceThe content effectively covers common issues and their solutions.
🧰 Tools
🪛 LanguageTool
[grammar] ~177-~177: The word “setup” is a noun. The verb is spelled with a space.
Context: ...odbus/). ## Troubleshooting ### Can’t setup the device - Make sure the device is n...(NOUN_VERB_CONFUSION)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
source/_integrations/fronius.markdown
(3 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/fronius.markdown
[uncategorized] ~25-~25: A comma might be missing here.
Context: ...interface of version v0
or v1
. This includes among others: - Agilo - Eco - Galvo - G...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[duplication] ~32-~32: Possible typo: you repeated a word
Context: ...Eco - Galvo - Gen24 - IG Plus - Primo - Symo - Symo Hybrid - Tauro Devices connected to th...
(ENGLISH_WORD_REPEAT_RULE)
[typographical] ~104-~104: It seems that a comma is missing.
Context: ...ide more data. When an endpoint is not responding correctly the update interval will increase to 10...
(IF_COMMA)
[grammar] ~109-~109: The noun should probably be in the singular form.
Context: ...y is connected to an inverter: Add each inverters Energy total
entity. - If a battery...
(EVERY_EACH_SINGULAR)
[grammar] ~177-~177: The word “setup” is a noun. The verb is spelled with a space.
Context: ...odbus/). ## Troubleshooting ### Can’t setup the device - Make sure the device is n...
(NOUN_VERB_CONFUSION)
🪛 Markdownlint (0.35.0)
source/_integrations/fronius.markdown
26-26: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
37-37: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
🔇 Additional comments (4)
source/_integrations/fronius.markdown (4)
44-48
: LGTM! Clear prerequisites section
The prerequisites are well-documented, especially the clarification about Solar API activation for Gen24 devices.
53-58
: LGTM! Well-structured configuration section
The configuration section follows Home Assistant documentation standards and clearly describes the required parameters.
171-174
: LGTM! Clear limitations section
The section effectively communicates the API limitations and provides a helpful alternative using Modbus.
191-195
: LGTM! Standard removal instructions
The section follows Home Assistant documentation standards for integration removal instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (4)
source/_integrations/fronius.markdown (4)
25-39
: Improve list formatting for better readabilityAdd blank lines around lists to improve readability and comply with markdown best practices.
The integration supports all inverters providing the Fronius SolarAPI (JSON) interface of version `v0` or `v1`. This includes among others: + - Agilo - Eco - Galvo - Gen24 - IG Plus - Primo - Symo - Symo Hybrid - Tauro + Devices connected to those inverters or dataloggers are supported as well. + - Energy meter (Fronius Smart Meter or S0 meter connected to the inverter) - Ohmpilot - Storage🧰 Tools
🪛 LanguageTool
[duplication] ~32-~32: Possible typo: you repeated a word
Context: ...Eco - Galvo - Gen24 - IG Plus - Primo - Symo - Symo Hybrid - Tauro Devices connected to th...(ENGLISH_WORD_REPEAT_RULE)
🪛 Markdownlint (0.35.0)
26-26: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
37-37: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
109-111
: Fix possessive form in the documentationThere's a grammatical error in the energy dashboard section.
- - If no battery is connected to an inverter: Add each inverters `Energy total` entity. + - If no battery is connected to an inverter: Add each inverter's `Energy total` entity.🧰 Tools
🪛 LanguageTool
[grammar] ~109-~109: The noun should probably be in the singular form.
Context: ...y is connected to an inverter: Add each invertersEnergy total
entity. - If a battery...(EVERY_EACH_SINGULAR)
134-164
: Enhance automation example with additional contextThe automation example is well-structured, but consider adding comments to explain:
- Why these specific threshold values (1000W and 50W) were chosen
- What typical use cases this automation serves
177-182
: Fix verb usage in troubleshooting headingThere's a grammatical error in the heading.
-### Can't setup the device +### Can't set up the device🧰 Tools
🪛 LanguageTool
[grammar] ~177-~177: The word “setup” is a noun. The verb is spelled with a space.
Context: ...odbus/). ## Troubleshooting ### Can’t setup the device - Make sure the device is n...(NOUN_VERB_CONFUSION)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
source/_integrations/fronius.markdown
(3 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/fronius.markdown
[duplication] ~32-~32: Possible typo: you repeated a word
Context: ...Eco - Galvo - Gen24 - IG Plus - Primo - Symo - Symo Hybrid - Tauro Devices connected to th...
(ENGLISH_WORD_REPEAT_RULE)
[typographical] ~104-~104: It seems that a comma is missing.
Context: ...ide more data. When an endpoint is not responding correctly the update interval will increase to 10...
(IF_COMMA)
[grammar] ~109-~109: The noun should probably be in the singular form.
Context: ...y is connected to an inverter: Add each inverters Energy total
entity. - If a battery...
(EVERY_EACH_SINGULAR)
[grammar] ~177-~177: The word “setup” is a noun. The verb is spelled with a space.
Context: ...odbus/). ## Troubleshooting ### Can’t setup the device - Make sure the device is n...
(NOUN_VERB_CONFUSION)
🪛 Markdownlint (0.35.0)
source/_integrations/fronius.markdown
26-26: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
37-37: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
🔇 Additional comments (2)
source/_integrations/fronius.markdown (2)
44-58
: LGTM! Clear and well-structured configuration documentation.
The prerequisites and configuration sections are well-documented, with clear instructions about the Solar API activation requirement and proper YAML configuration formatting.
171-174
: LGTM! Clear documentation of limitations and alternatives.
The section effectively communicates the API limitations and provides a helpful alternative using the Modbus integration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (6)
source/_integrations/fronius.markdown (6)
47-49
: Consider adding navigation steps for Gen24 Solar API activation.The note about activating "Solar API" could be more helpful by including the specific steps to locate this setting in the inverter's web interface.
Consider adding:
-For Gen24 devices (delivered with Firmware >= 1.14.1) make sure to activate "Solar API" in the inverters web interface. For older devices, Solar API should be enabled by default. +For Gen24 devices (delivered with Firmware >= 1.14.1) make sure to activate "Solar API" in the inverter's web interface: +1. Navigate to "Settings" → "System" → "Network" +2. Enable the "Solar API" toggle + +For older devices, Solar API should be enabled by default.
109-109
: Add a comma after "correctly" for better readability.-When an endpoint is not responding correctly the update interval will increase +When an endpoint is not responding correctly, the update interval will increase🧰 Tools
🪛 LanguageTool
[typographical] ~109-~109: It seems that a comma is missing.
Context: ... every minute. When an endpoint is not responding correctly the update interval will increase to 10...(IF_COMMA)
116-116
: Fix possessive form of "inverter".-Add each inverters `Energy total` entity +Add each inverter's `Energy total` entity🧰 Tools
🪛 LanguageTool
[grammar] ~116-~116: The noun should probably be in the singular form.
Context: ...y is connected to an inverter: Add each invertersEnergy total
entity. - If a battery...(EVERY_EACH_SINGULAR)
141-171
: Optimize the automation example.The automation example is clear but contains unnecessary empty dictionaries.
Consider simplifying:
- action: switch.turn_on - metadata: {} - data: {} target: entity_id: switch.swtest - action: switch.turn_off - metadata: {} - data: {} target: entity_id: switch.swtest
180-180
: Add commas around "however" for proper punctuation.-Most Fronius devices however do support Modbus TCP directly +Most Fronius devices, however, do support Modbus TCP directly🧰 Tools
🪛 LanguageTool
[typographical] ~180-~180: Consider adding two commas here.
Context: ...he Fronius devices. Most Fronius devices however do support Modbus TCP directly, so the ...(HOWEVER_COMMA)
184-184
: Fix verb form of "set up".-Can't setup the device +Can't set up the device🧰 Tools
🪛 LanguageTool
[grammar] ~184-~184: The word “setup” is a noun. The verb is spelled with a space.
Context: ...s.com/). ## Troubleshooting ### Can’t setup the device - Make sure the device is n...(NOUN_VERB_CONFUSION)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
source/_integrations/fronius.markdown
(4 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/fronius.markdown
[duplication] ~33-~33: Possible typo: you repeated a word
Context: ...Eco - Galvo - Gen24 - IG Plus - Primo - Symo - Symo Hybrid - Tauro Devices connected to th...
(ENGLISH_WORD_REPEAT_RULE)
[typographical] ~109-~109: It seems that a comma is missing.
Context: ... every minute. When an endpoint is not responding correctly the update interval will increase to 10...
(IF_COMMA)
[grammar] ~116-~116: The noun should probably be in the singular form.
Context: ...y is connected to an inverter: Add each inverters Energy total
entity. - If a battery...
(EVERY_EACH_SINGULAR)
[typographical] ~180-~180: Consider adding two commas here.
Context: ...he Fronius devices. Most Fronius devices however do support Modbus TCP directly, so the ...
(HOWEVER_COMMA)
[grammar] ~184-~184: The word “setup” is a noun. The verb is spelled with a space.
Context: ...s.com/). ## Troubleshooting ### Can’t setup the device - Make sure the device is n...
(NOUN_VERB_CONFUSION)
🔇 Additional comments (2)
source/_integrations/fronius.markdown (2)
23-41
: LGTM! Well-structured device compatibility list.
The new "Supported devices" section provides clear and comprehensive information about compatible Fronius inverters and connected devices.
🧰 Tools
🪛 LanguageTool
[duplication] ~33-~33: Possible typo: you repeated a word
Context: ...Eco - Galvo - Gen24 - IG Plus - Primo - Symo - Symo Hybrid - Tauro Devices connected to th...
(ENGLISH_WORD_REPEAT_RULE)
Line range hint 1-203
: Documentation updates look great overall!
The changes significantly improve the documentation by:
- Adding comprehensive device compatibility information
- Providing clear configuration instructions
- Including practical examples
- Adding helpful troubleshooting guidance
The structure follows Home Assistant's documentation standards, and the content is well-organized and informative.
🧰 Tools
🪛 LanguageTool
[typographical] ~180-~180: Consider adding two commas here.
Context: ...he Fronius devices. Most Fronius devices however do support Modbus TCP directly, so the ...
(HOWEVER_COMMA)
[grammar] ~184-~184: The word “setup” is a noun. The verb is spelled with a space.
Context: ...s.com/). ## Troubleshooting ### Can’t setup the device - Make sure the device is n...
(NOUN_VERB_CONFUSION)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (6)
source/_integrations/fronius.markdown (6)
47-49
: Add more specific instructions for Gen24 setup.Consider adding step-by-step instructions for activating the "Solar API" in Gen24 devices, such as the menu path in the web interface.
Would you like me to propose detailed setup instructions for Gen24 devices?
109-109
: Add missing comma for better readability.-When an endpoint is not responding correctly the update interval will increase +When an endpoint is not responding correctly, the update interval will increase🧰 Tools
🪛 LanguageTool
[typographical] ~109-~109: It seems that a comma is missing.
Context: ... every minute. When an endpoint is not responding correctly the update interval will increase to 10...(IF_COMMA)
116-116
: Fix grammar in entity reference.-Add each inverters `Energy total` entity +Add each inverter's `Energy total` entity🧰 Tools
🪛 LanguageTool
[grammar] ~116-~116: The noun should probably be in the singular form.
Context: ...y is connected to an inverter: Add each invertersEnergy total
entity. - If a battery...(EVERY_EACH_SINGULAR)
160-160
: Add a note about the example entity ID.Consider adding a comment to clarify that
switch.swtest
is just an example and should be replaced with the user's actual entity ID.
180-180
: Add missing commas around "however".-Most Fronius devices however do support Modbus TCP directly +Most Fronius devices, however, do support Modbus TCP directly🧰 Tools
🪛 LanguageTool
[typographical] ~180-~180: Consider adding two commas here.
Context: ...he Fronius devices. Most Fronius devices however do support Modbus TCP directly, so the ...(HOWEVER_COMMA)
184-184
: Fix verb form of "set up".-Can't setup the device +Can't set up the device🧰 Tools
🪛 LanguageTool
[grammar] ~184-~184: The word “setup” is a noun. The verb is spelled with a space.
Context: ...s.com/). ## Troubleshooting ### Can’t setup the device - Make sure the device is n...(NOUN_VERB_CONFUSION)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
source/_integrations/fronius.markdown
(4 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/fronius.markdown
[duplication] ~33-~33: Possible typo: you repeated a word
Context: ...Eco - Galvo - Gen24 - IG Plus - Primo - Symo - Symo Hybrid - Tauro Devices connected to th...
(ENGLISH_WORD_REPEAT_RULE)
[typographical] ~109-~109: It seems that a comma is missing.
Context: ... every minute. When an endpoint is not responding correctly the update interval will increase to 10...
(IF_COMMA)
[grammar] ~116-~116: The noun should probably be in the singular form.
Context: ...y is connected to an inverter: Add each inverters Energy total
entity. - If a battery...
(EVERY_EACH_SINGULAR)
[typographical] ~180-~180: Consider adding two commas here.
Context: ...he Fronius devices. Most Fronius devices however do support Modbus TCP directly, so the ...
(HOWEVER_COMMA)
[grammar] ~184-~184: The word “setup” is a noun. The verb is spelled with a space.
Context: ...s.com/). ## Troubleshooting ### Can’t setup the device - Make sure the device is n...
(NOUN_VERB_CONFUSION)
🔇 Additional comments (3)
source/_integrations/fronius.markdown (3)
23-41
: LGTM! Well-structured device compatibility list.
The new "Supported devices" section provides clear and comprehensive information about compatible Fronius inverters and connected devices.
🧰 Tools
🪛 LanguageTool
[duplication] ~33-~33: Possible typo: you repeated a word
Context: ...Eco - Galvo - Gen24 - IG Plus - Primo - Symo - Symo Hybrid - Tauro Devices connected to th...
(ENGLISH_WORD_REPEAT_RULE)
134-135
: LGTM! Clear energy dashboard configuration instructions.
The Riemann sum integration recommendations are well-explained and provide proper guidance for energy calculations.
178-198
: LGTM! Comprehensive troubleshooting guide.
The Known Limitations and Troubleshooting sections provide valuable information for users, covering common issues and their solutions.
🧰 Tools
🪛 LanguageTool
[typographical] ~180-~180: Consider adding two commas here.
Context: ...he Fronius devices. Most Fronius devices however do support Modbus TCP directly, so the ...
(HOWEVER_COMMA)
[grammar] ~184-~184: The word “setup” is a noun. The verb is spelled with a space.
Context: ...s.com/). ## Troubleshooting ### Can’t setup the device - Make sure the device is n...
(NOUN_VERB_CONFUSION)
Proposed change
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
New Features
Documentation