-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update serial.markdown #36052
base: current
Are you sure you want to change the base?
Update serial.markdown #36052
Conversation
Added note for socat & ser2net to prevent future users searching for hours to get it up and running.
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe changes involve an update to the documentation for the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HomeAssistant
participant SerialIntegration
participant Tools
User->>HomeAssistant: Request to set up serial sensor integration
HomeAssistant->>SerialIntegration: Provide configuration instructions
SerialIntegration->>Tools: Check for availability of `ser2net` and `socat`
Tools-->>SerialIntegration: Confirm availability
SerialIntegration-->>HomeAssistant: Return configuration details
HomeAssistant-->>User: Provide setup instructions
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI is failing, could you please take a look?
Thanks! 👍
../Frenck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong button, trying again.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Added 'not', as my initial change was not specific enough. I am using socat since more than 10 years on other systems. Reason of the PR is that the reference to socat and ser2net in this doc already confused a lot of people and made them waste their time (including myself - 2 long evenings of research and try-and-error, without any result). My conclusion is the same as a bunch of other people had before: There is not legit / stable way to integrate it into HASS OS, as it requires additional driver installations, which are lost on next reboot.
Added note for socat & ser2net to prevent future users searching for hours to get it up and running.
Proposed change
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
ser2net
andsocat
on HASS OS for theserial
sensor integration.serial
sensor integration.