Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add binary sensors to IronOS integration #36070

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Add binary sensors to IronOS integration #36070

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ba855d
Add binary sensors to IronOS integration
tr4nt0r Nov 30, 2024
59eabdc
Fix typo
frenck Dec 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions source/_integrations/iron_os.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ ha_category:
- Number
- Sensor
- Update
- Binary sensor
ha_iot_class: Local Polling
ha_release: 2024.8
ha_config_flow: true
Expand All @@ -16,6 +17,7 @@ ha_platforms:
- number
- sensor
- update
- binary_sensor
---

The **IronOS** {% term integration %} seamlessly connects Home Assistant with PINE64's Pinecil V2 soldering irons, allowing for remote monitoring and control. This integration provides real-time updates on temperature, power, and various other settings and diagnostic information.
Expand All @@ -30,6 +32,10 @@ The **IronOS** {% term integration %} seamlessly connects Home Assistant with PI

- **Setpoint temperature:** Allows to set the desired target temperature for the soldering iron tip.

## Binary sensors

- **Soldering tip:** Indicates wether a soldering tip is currently connected to the device.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Fix typo and enhance sensor description

  1. There's a typo in the description: "wether" should be "whether"
  2. Consider enhancing the description to explicitly state the possible states (true/false) and their meanings
- - **Soldering tip:** Indicates wether a soldering tip is currently connected to the device.
+ - **Soldering tip:** Indicates whether a soldering tip is currently connected to the device (true = connected, false = disconnected).
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
## Binary sensors
- **Soldering tip:** Indicates wether a soldering tip is currently connected to the device.
## Binary sensors
- **Soldering tip:** Indicates whether a soldering tip is currently connected to the device (true = connected, false = disconnected).

frenck marked this conversation as resolved.
Show resolved Hide resolved
frenck marked this conversation as resolved.
Show resolved Hide resolved

## Sensors

- **Tip temperature:** Monitors the current temperature of the soldering iron tip.
Expand Down