-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add important note to Synology DSM docs to not modify the backup files manually #37289
Add important note to Synology DSM docs to not modify the backup files manually #37289
Conversation
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe documentation for the Synology DSM integration has been updated to include a clearly formatted warning. The warning advises users against manually deleting or renaming files in the NAS backup path, as doing so may disrupt the ability to read or restore backups. The overall content and structure remain unchanged except for the addition of this important note. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/synology_dsm.markdown (1)
72-77
: Review the newly added important note blockThe newly added important note is correctly formatted using the
{% important %}
tags and is placed appropriately within the "Backup location" section. It provides a clear and critical warning about modifying the backup files, which aligns well with the PR objectives.For slight clarity and consistency with formal documentation style, you might consider a rewording such as:
-{% important %} -Don't manually delete or rename the files in the backup path on the NAS. This could result in the backups no longer being able to be read or restored. -{% endimportant %} +{% important %} +Do not manually delete or rename files in the NAS backup path, as doing so may render backups unreadable or non-restorable. +{% endimportant %}This is an optional suggestion to enhance clarity, and the current wording is acceptable if it aligns with your documentation style.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/synology_dsm.markdown
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @mib1185 👍
Proposed change
SSIA
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit