Fix icon display after DOM has been modified on tree #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses textContent for file instead of innerText as textContent uses markup and doesn't wait for render. Removed isDirectory variable as it can be checked once. Removed Promise as it causes flikering. Improved File Tree Icons selector, so it doesn't account for Loading state ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes the icon display after DOM is modified on tree view (Issue #149).
This pull request also fixes the import of domLoaded as it's not well imported and not awaited.
Current Version of Tree View:
broken.mp4
This Pull Request version of Tree View:
WOrking.version.mp4