perf(types): replace intersection with union to get better perf

honojs · Sep 23, 2024 · 06610f8 · 06610f8
1 parent e1eb98d
commit 06610f8
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/types.ts b/src/types.ts
@@ -104,6 +104,7 @@ export type ErrorHandler<E extends Env = any> = (
 //////                            //////
 ////////////////////////////////////////
 
+
 export interface HandlerInterface<
   E extends Env = Env,
   M extends string = string,
@@ -146,7 +147,7 @@ export interface HandlerInterface<
   >(
     path: P,
     handler: H<E2, MergedPath, I, R>
-  ): Hono<E, S & ToSchema<M, MergePath<BasePath, P>, I, MergeTypedResponse<R>>, BasePath>
+  ): Hono<E, ExcludeEmptyObject<S | ToSchema<M, MergePath<BasePath, P>, I, MergeTypedResponse<R>>>, BasePath>
 
   // app.get(handler x 3)
   <
@@ -1988,6 +1989,8 @@ type IntersectNonAnyTypes<T extends any[]> = T extends [infer Head, ...infer Res
   ? IfAnyThenEmptyObject<EnvOrEmpty<Head>> & IntersectNonAnyTypes<Rest>
   : {}
 
+type ExcludeEmptyObject<T> = T extends {} ? {} extends T ? never : T : T
+
 ////////////////////////////////////////
 //////                            //////
 //////         FetchEvent         //////