Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): correct inferring empty object fromc.json({}) #3873

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yusukebe
Copy link
Member

Fixes #3868

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

Bundle size check

main (d72aa4b) #3873 (db7b1fd) +/-
Bundle Size (B) 18,771B 18,771B 0B
Bundle Size (KB) 18.33K 18.33K 0K

Compiler Diagnostics

main (d72aa4b) #3873 (db7b1fd) +/-
Files 257 257 0
Lines 115,048 115,035 -13
Identifiers 112,929 112,922 -7
Symbols 301,429 301,427 -2
Types 213,638 213,633 -5
Instantiations 3,090,073 3,090,066 -7
Memory used 444,135K 446,554K 2,419K
I/O read 0.02s 0.03s 0.01s
I/O write 0s 0s 0s
Parse time 0.85s 0.65s -0.2s
Bind time 0.31s 0.27s -0.04s
Check time 5.3s 5.32s 0.02s
Emit time 0s 0s 0s
Total time 6.46s 6.24s -0.22s

Reported by octocov

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.33%. Comparing base (d72aa4b) to head (85239bf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3873   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files         162      162           
  Lines       10257    10257           
  Branches     2900     2938   +38     
=======================================
  Hits         9368     9368           
  Misses        888      888           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusukebe yusukebe added the v4.7 label Jan 31, 2025
@yusukebe
Copy link
Member Author

@meows Can you review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hono treats empty object {} as type never for RPC
1 participant