Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adapter/aws-lambda): APIGWProxyResult should contain either of headers or multiValueHeaders, not both #3883

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Feb 1, 2025

Closes #3870

  • APIGWProxyResult now contains headers or multiValueHeaders mutually-exclusively.
  • handle is tweaked so the response type can be inferred from the request event type.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

… headers or multiValueHeaders, not both, to avoid confusing

header merge mechanism
@exoego exoego changed the title fix(adapter/aws-lambda): API GW Proxy Result should contain either of headers or multiValueHeaders, not both fix(adapter/aws-lambda): APIGWProxyResult should contain either of headers or multiValueHeaders, not both Feb 1, 2025
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.77%. Comparing base (093d3fd) to head (ed5fe62).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3883      +/-   ##
==========================================
- Coverage   90.78%   90.77%   -0.01%     
==========================================
  Files         162      162              
  Lines       10263    10259       -4     
  Branches     2908     2900       -8     
==========================================
- Hits         9317     9313       -4     
  Misses        945      945              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-lambda duplicate headers in API Gateway V1 response
1 participant