Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate from lit-html to vue #304

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore: migrate from lit-html to vue #304

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d70c820
Initialised Vue
Jul 21, 2024
77f1339
Vue initialised and setup
Jul 21, 2024
d42fb49
Rewrote entire logic in vue js
Jul 22, 2024
7eae992
Made the delete icon colour change
Jul 22, 2024
15f3101
Resolved all the issues as pointed out
The-x-35 Aug 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .DS_Store
View file
Open in desktop
Binary file not shown.
7 changes: 5 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"@parcel/plugin": "^2.10.0",
"@parcel/transformer-inline-string": "2.10.0",
"@parcel/transformer-raw": "^2.10.0",
"@parcel/transformer-vue": "2.10.0",
"@types/chrome": "^0.0.246",
"@types/node": "^17.0.23",
"buffer": "^6.0.3",
Expand All @@ -27,6 +28,8 @@
"dependencies": {
"axios": "^1.5.1",
"lit": "^3.1.3",
"lit-html": "^3.0.0"
}
"lit-html": "^3.0.0",
The-x-35 marked this conversation as resolved.
Show resolved Hide resolved
"vue": "^3.4.33"
},
"packageManager": "[email protected]+sha256.dbdf5961c32909fb030595a9daa1dae720162e658609a8f92f2fa99835510ca5"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are discussions happening on the node level to remove some ambiguity with defining package managers like this.

we can revisit this once we've more clarity on the matter on industry level. for now we can remove it.

Copy link
Author

@The-x-35 The-x-35 Aug 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sir I have not added this line, it was added implicitly by the corepack and when I try to remove it and try to build the project again, it gets added back automatically by the corepack. You can see in the below screenshot

image

I checked the docs and could not find a way to remove it, so keeping this in the next commit in this PR.

}
Loading